Skip to content

Commit 0ab7c5f

Browse files
authored
test(solid-query/suspense): replace the 'TODO(lukemurray)' comments with notes explaining why the state counts differ from react (#12300)
1 parent 6580131 commit 0ab7c5f

1 file changed

Lines changed: 2 additions & 5 deletions

File tree

‎packages/solid-query/src/__tests__/suspense.test.tsx‎

Lines changed: 2 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -121,9 +121,7 @@ describe("useQuery's in Suspense mode", () => {
121121
expect(rendered.getByText('loading')).toBeInTheDocument()
122122
await vi.advanceTimersByTimeAsync(10)
123123
expect(rendered.getByText('data: 1')).toBeInTheDocument()
124-
// oxlint-disable-next-line cspell/spellchecker
125-
// TODO(lukemurray): in react this is 1 in solid this is 2 because suspense
126-
// occurs on read.
124+
// In react this is 1, but in solid it is 2 because suspense occurs on read.
127125
expect(states).toHaveLength(2)
128126
expect(states[1]).toMatchObject({
129127
data: { pages: [1], pageParams: [1] },
@@ -134,8 +132,7 @@ describe("useQuery's in Suspense mode", () => {
134132
expect(rendered.getByText('loading')).toBeInTheDocument()
135133
await vi.advanceTimersByTimeAsync(10)
136134
expect(rendered.getByText('data: 2')).toBeInTheDocument()
137-
// oxlint-disable-next-line cspell/spellchecker
138-
// TODO(lukemurray): in react this is 2 and in solid it is 4
135+
// In react this is 2, but in solid it is 4 because suspense occurs on read.
139136
expect(states).toHaveLength(4)
140137
expect(states[3]).toMatchObject({
141138
data: { pages: [2], pageParams: [1] },

0 commit comments

Comments
 (0)