From 04dd710a379de0778ae9ed9f7dfe90e25c2497f5 Mon Sep 17 00:00:00 2001 From: David Butenhof Date: Wed, 30 Sep 2026 08:57:03 -0400 Subject: [PATCH] Allow milestone edit Also defer re-fetch on date picker until APPLY. Signed-off-by: David Butenhof --- backend/src/github_pm/api.py | 23 +++ frontend/src/App.jsx | 9 ++ frontend/src/components/MilestoneCard.jsx | 136 +++++++++++++++++- .../src/components/ProjectStatusPanel.jsx | 2 - .../components/ProjectStatusPanel.test.jsx | 47 ++++++ frontend/src/services/api.js | 15 ++ 6 files changed, 228 insertions(+), 4 deletions(-) diff --git a/backend/src/github_pm/api.py b/backend/src/github_pm/api.py index daf8132..9cc72d6 100644 --- a/backend/src/github_pm/api.py +++ b/backend/src/github_pm/api.py @@ -668,6 +668,13 @@ class CreateMilestone(BaseModel): due_on: datetime | None = Field(default=None, title="Milestone Due Date") +# Assisted-by: openai-code-assist +class UpdateMilestone(BaseModel): + title: str = Field(title="Milestone Title") + description: str | None = Field(default=None, title="Milestone Description") + due_on: datetime | None = Field(default=None, title="Milestone Due Date") + + @api_router.post("/milestones") async def create_milestone( gitctx: Annotated[Connector, Depends(connection)], @@ -687,6 +694,22 @@ async def create_milestone( return m +@api_router.patch("/milestones/{milestone_number}") +async def update_milestone( + gitctx: Annotated[Connector, Depends(connection)], + milestone_number: Annotated[int, Path(title="Milestone")], + milestone: Annotated[UpdateMilestone, Body(title="Milestone")], +): + data = { + "title": milestone.title, + "description": milestone.description, + "due_on": milestone.due_on.isoformat() if milestone.due_on else None, + } + return gitctx.patch( + f"/repos/{context.github_repo}/milestones/{milestone_number}", data=data + ) + + @api_router.delete("/milestones/{milestone_number}") async def delete_milestone( gitctx: Annotated[Connector, Depends(connection)], diff --git a/frontend/src/App.jsx b/frontend/src/App.jsx index ce4337b..d9b1306 100644 --- a/frontend/src/App.jsx +++ b/frontend/src/App.jsx @@ -292,6 +292,14 @@ const App = () => { // but we can add a callback if needed in the future }; + const handleMilestoneUpdated = (updatedMilestone) => { + setMilestones((current) => + current.map((item) => + item.number === updatedMilestone.number ? updatedMilestone : item + ) + ); + }; + const renderPlanningContent = () => ( { hierarchyAction={hierarchyAction} onIssueMilestoneMoved={handleIssueMilestoneMoved} onIssueLabelsChanged={handleIssueLabelsChanged} + onMilestoneUpdated={handleMilestoneUpdated} /> ))} diff --git a/frontend/src/components/MilestoneCard.jsx b/frontend/src/components/MilestoneCard.jsx index 1adb902..2f68622 100644 --- a/frontend/src/components/MilestoneCard.jsx +++ b/frontend/src/components/MilestoneCard.jsx @@ -10,8 +10,14 @@ import { Alert, ExpandableSection, Button, + Modal, + Form, + FormGroup, + TextInput, + TextArea, } from '@patternfly/react-core'; -import { fetchIssues, createIssue } from '../services/api'; +import { fetchIssues, createIssue, updateMilestone } from '../services/api'; +import milestonesCache from '../utils/milestonesCache'; import IssueCard from './IssueCard'; import MarkdownInputModal from './MarkdownInputModal'; import { usePlanningDnD } from './PlanningDnDContext'; @@ -55,6 +61,7 @@ const MilestoneCard = ({ onIssueMilestoneMoved, onIssueLabelsChanged, hierarchyAction, + onMilestoneUpdated, }) => { const [isIssuesExpanded, setIsIssuesExpanded] = useState(false); const [isPrsExpanded, setIsPrsExpanded] = useState(false); @@ -65,10 +72,57 @@ const MilestoneCard = ({ const [hasLoadedOnce, setHasLoadedOnce] = useState(false); const [expandedHierarchy, setExpandedHierarchy] = useState(() => new Set()); const [isCreateIssueOpen, setIsCreateIssueOpen] = useState(false); + const [isEditOpen, setIsEditOpen] = useState(false); + const [editMilestone, setEditMilestone] = useState({ + title: '', + description: '', + due_on: '', + }); + const [editError, setEditError] = useState(null); + const [isSavingEdit, setIsSavingEdit] = useState(false); const prevMilestoneNumberRef = useRef(milestone.number); const lastAppliedHierarchyKeyRef = useRef(null); const dnd = usePlanningDnD(); + const openMilestoneEditor = () => { + setEditMilestone({ + title: milestone.title || '', + description: milestone.description || '', + due_on: milestone.due_on ? milestone.due_on.slice(0, 10) : '', + }); + setEditError(null); + setIsEditOpen(true); + }; + + const saveMilestoneEdit = async () => { + const title = editMilestone.title.trim(); + if (!title) { + setEditError('Title is required'); + return; + } + setIsSavingEdit(true); + setEditError(null); + try { + const updated = await updateMilestone(milestone.number, { + title, + description: editMilestone.description.trim() || null, + due_on: editMilestone.due_on + ? `${editMilestone.due_on}T00:00:00Z` + : null, + }); + const nextMilestone = { ...milestone, ...updated }; + milestonesCache.data = milestonesCache.data.map((item) => + item.number === milestone.number ? nextMilestone : item + ); + onMilestoneUpdated?.(nextMilestone); + setIsEditOpen(false); + } catch (err) { + setEditError(err.message); + } finally { + setIsSavingEdit(false); + } + }; + const applyFetchedData = useCallback((data) => { setIssues(data.issues || []); setPullRequests(data.pull_requests || []); @@ -443,7 +497,15 @@ const MilestoneCard = ({ flexWrap: 'wrap', }} > - {milestone.title} + + + {milestone.title} + + , + , + ]} + > +
+ + + setEditMilestone((prev) => ({ ...prev, title: value })) + } + /> + + +