From 3ce5697b8dcab54086f65606967e9e6a151b44f6 Mon Sep 17 00:00:00 2001 From: Miguel Angel Simon Sierra Date: Sun, 25 Oct 2026 18:54:18 -0400 Subject: [PATCH] test(cli): wait for the lookup child to die after the CLI exits --- packages/cli/src/capture/publicNetwork.process.test.ts | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/packages/cli/src/capture/publicNetwork.process.test.ts b/packages/cli/src/capture/publicNetwork.process.test.ts index 3f7d6a3320f..5c94a1c95b5 100644 --- a/packages/cli/src/capture/publicNetwork.process.test.ts +++ b/packages/cli/src/capture/publicNetwork.process.test.ts @@ -3,7 +3,7 @@ import { dirname, join } from "node:path"; import { fileURLToPath } from "node:url"; import { expect, it, onTestFinished } from "vitest"; import { startTestDnsServer } from "../utils/dnsTestServer.js"; -import { testProcessIsAlive } from "../utils/processTestUtils.js"; +import { testProcessIsAlive, waitForTestCondition } from "../utils/processTestUtils.js"; import { systemLookupInKillableChild } from "./publicNetwork.js"; const fixture = join(dirname(fileURLToPath(import.meta.url)), "publicNetwork.fixture.ts"); @@ -76,7 +76,7 @@ it("leaves no system lookup running when the CLI exits mid-lookup", async () => const pid = Number(/^exit (\d+)$/m.exec(run.printed)?.[1]); onTestFinished(() => void (testProcessIsAlive(pid) && process.kill(pid, "SIGKILL"))); expect(pid).toBeGreaterThan(0); - expect(testProcessIsAlive(pid)).toBe(false); + await waitForTestCondition(() => !testProcessIsAlive(pid), 5_000); }, 30_000); it("runs the real system lookup in its child", async () => {