address copilot comments

Author: yec-akamai

linode_api4/groups/linode.py

@@ -163,14 +163,14 @@ def instance_create(
         interface_generation: Optional[Union[InterfaceGeneration, str]] = None,
         network_helper: Optional[bool] = None,
         maintenance_policy: Optional[str] = None,
-        alerts: Optional[
-            Union[Dict[str, Any], InstanceACLPAlertsOptions]
-        ] = None,
         root_pass: Optional[str] = None,
         kernel: Optional[str] = None,
         boot_size: Optional[int] = None,
         authorized_users: Optional[List[str]] = None,
         ipv4: Optional[List[str]] = None,
+        alerts: Optional[
+            Union[Dict[str, Any], InstanceACLPAlertsOptions]
+        ] = None,
         **kwargs,
     ):
         """
@@ -354,9 +354,6 @@ def instance_create(
         :param maintenance_policy: The slug of the maintenance policy to apply during maintenance.
                                       If not provided, the default policy (linode/migrate) will be applied.
         :type maintenance_policy: str
-        :param alerts: ACLP alerts available to define during instance creation.
-                        This is v4beta only and may not be available to all users.
-        :type alerts: dict[str, Any] or InstanceACLPAlertsOptions
         :param kernel: The kernel to boot the Instance with. If provided, this will be used as the
                        kernel for the default configuration profile.
         :type kernel: str
@@ -366,6 +363,9 @@ def instance_create(
         :param ipv4: A list of reserved IPv4 addresses to assign to this Instance.
                      NOTE: Reserved IP feature may not currently be available to all users.
         :type ipv4: list[str]
+        :param alerts: ACLP alerts available to define during instance creation.
+                        This is v4beta only and may not be available to all users.
+        :type alerts: dict[str, Any] or InstanceACLPAlertsOptions
 
         :returns: A new Instance object
         :rtype: Instance

test/integration/models/linode/test_linode.py

@@ -458,6 +458,7 @@ def test_linode_alerts_workflow(test_linode_client, create_linode):
     }
     linode_save_status = linode.save()
     assert linode_save_status == True
+    linode = test_linode_client.load(Instance, parent_linode_id)
     assert linode.alerts["cpu"] == 50
     assert linode.alerts["io"] == 6000
     assert linode.alerts["network_in"] == 20
@@ -472,15 +473,17 @@ def test_linode_alerts_workflow(test_linode_client, create_linode):
         instance_type=linode.type.id,
         label=get_test_label(),
     )
-    assert new_linode.alerts.cpu == 90
-    assert new_linode.alerts.io == 10000
-    assert new_linode.alerts.network_in == 10
-    assert new_linode.alerts.network_out == 10
-    assert new_linode.alerts.transfer_quota == 80
-    assert isinstance(new_linode.alerts.system_alerts, list)
-    assert isinstance(new_linode.alerts.user_alerts, list)
 
-    wait_for_clone_complete_and_delete_linode(10, 100, new_linode)
+    try:
+        assert new_linode.alerts.cpu == 90
+        assert new_linode.alerts.io == 10000
+        assert new_linode.alerts.network_in == 10
+        assert new_linode.alerts.network_out == 10
+        assert new_linode.alerts.transfer_quota == 80
+        assert isinstance(new_linode.alerts.system_alerts, list)
+        assert isinstance(new_linode.alerts.user_alerts, list)
+    finally:
+        wait_for_clone_complete_and_delete_linode(10, 100, new_linode)
 
 
 def test_update_linode_aclp_alerts(
@@ -494,6 +497,7 @@ def test_update_linode_aclp_alerts(
         "system_alerts": [sample_system_alert],
     }
     linode.save()
+    linode = test_linode_client.load(Instance, linode.id)
     assert linode.alerts["user_alerts"] == [create_alert_service_definition.id]
     assert linode.alerts["system_alerts"] == [sample_system_alert]