diff --git a/launch/core/platforms/linux.py b/launch/core/platforms/linux.py index bd87786..17bb43b 100644 --- a/launch/core/platforms/linux.py +++ b/launch/core/platforms/linux.py @@ -248,6 +248,16 @@ def _start_container( "cpu_quota": int(CPU_CORES * 100000), "mem_limit": MEM_LIMIT, } + # Keep Linux sandboxes device-isolated by default. Consumers that need + # a narrowly scoped device (for example, NetBird tests that exercise + # WireGuard through /dev/net/tun) can opt in explicitly. + requested_devices = [ + device.strip() + for device in os.environ.get("SWE_BENCH_LIVE_DOCKER_DEVICES", "").split(",") + if device.strip() + ] + if requested_devices: + run_kwargs["devices"] = requested_devices container = client.containers.run( image_name, diff --git a/tests/linux_docker_capabilities_test.py b/tests/linux_docker_capabilities_test.py new file mode 100644 index 0000000..535b251 --- /dev/null +++ b/tests/linux_docker_capabilities_test.py @@ -0,0 +1,59 @@ +import os +import sys +from unittest.mock import MagicMock, patch + +ROOT = os.path.dirname(os.path.dirname(__file__)) +sys.path.insert(0, ROOT) + +from launch.core.platforms.linux import LinuxRuntime + + +def _start_runtime(monkeypatch, devices=None): + captured = {} + + class FakeContainer: + def attach_socket(self, **_kwargs): + return object() + + class FakeContainers: + def run(self, *_args, **kwargs): + captured.update(kwargs) + return FakeContainer() + + class FakeClient: + containers = FakeContainers() + + def version(self): + return {"Os": "linux"} + + class FakeDocker: + def ping(self): + return True + + if devices is None: + monkeypatch.delenv("SWE_BENCH_LIVE_DOCKER_DEVICES", raising=False) + else: + monkeypatch.setenv("SWE_BENCH_LIVE_DOCKER_DEVICES", devices) + + with patch("launch.core.platforms.linux.docker.from_env", side_effect=[FakeDocker(), FakeClient()]), patch.object( + LinuxRuntime, "pull_image", return_value=None + ), patch.object(LinuxRuntime, "_clear_initial_prompt", return_value=None), patch.object( + LinuxRuntime, "send_command", return_value=MagicMock() + ): + LinuxRuntime._start_container("task-image", "task-id", 30, 1) + return captured + + +def test_linux_runtime_keeps_devices_disabled_by_default(monkeypatch): + captured = _start_runtime(monkeypatch) + + assert "devices" not in captured + + +def test_linux_runtime_passes_trimmed_opt_in_devices(monkeypatch): + captured = _start_runtime( + monkeypatch, + devices=" /dev/net/tun:/dev/net/tun:rwm, , /dev/kvm ", + ) + + assert captured["devices"] == ["/dev/net/tun:/dev/net/tun:rwm", "/dev/kvm"] \ No newline at end of file