From e83babf49278efebf02d8d21ff592120bd2fd7ae Mon Sep 17 00:00:00 2001 From: "Slai.life" Date: Mon, 26 Oct 2026 18:10:39 +0800 Subject: [PATCH] Allow opt-in DNS servers for Linux test sandboxes --- launch/core/platforms/linux.py | 10 ++++++ tests/test_linux_docker_dns.py | 57 ++++++++++++++++++++++++++++++++++ 2 files changed, 67 insertions(+) create mode 100644 tests/test_linux_docker_dns.py diff --git a/launch/core/platforms/linux.py b/launch/core/platforms/linux.py index bd87786..af9421e 100644 --- a/launch/core/platforms/linux.py +++ b/launch/core/platforms/linux.py @@ -248,6 +248,16 @@ def _start_container( "cpu_quota": int(CPU_CORES * 100000), "mem_limit": MEM_LIMIT, } + # Preserve Docker Engine DNS by default. An evaluator may explicitly + # request reviewed nameservers for a network-dependent task when the + # engine resolver cannot reach the required public DNS service. + requested_nameservers = [ + nameserver.strip() + for nameserver in os.environ.get("SWE_BENCH_LIVE_DOCKER_DNS", "").split(",") + if nameserver.strip() + ] + if requested_nameservers: + run_kwargs["dns"] = requested_nameservers container = client.containers.run( image_name, diff --git a/tests/test_linux_docker_dns.py b/tests/test_linux_docker_dns.py new file mode 100644 index 0000000..11232bb --- /dev/null +++ b/tests/test_linux_docker_dns.py @@ -0,0 +1,57 @@ +import os +import sys +from unittest.mock import MagicMock, patch + + +ROOT = os.path.dirname(os.path.dirname(__file__)) +sys.path.insert(0, ROOT) + +from launch.core.platforms.linux import LinuxRuntime + + +def _start_runtime(monkeypatch, nameservers=None): + captured = {} + + class FakeContainer: + def attach_socket(self, **_kwargs): + return object() + + class FakeContainers: + def run(self, *_args, **kwargs): + captured.update(kwargs) + return FakeContainer() + + class FakeClient: + containers = FakeContainers() + + def version(self): + return {"Os": "linux"} + + class FakeDocker: + def ping(self): + return True + + if nameservers is None: + monkeypatch.delenv("SWE_BENCH_LIVE_DOCKER_DNS", raising=False) + else: + monkeypatch.setenv("SWE_BENCH_LIVE_DOCKER_DNS", nameservers) + + with patch("launch.core.platforms.linux.docker.from_env", side_effect=[FakeDocker(), FakeClient()]), patch.object( + LinuxRuntime, "pull_image", return_value=None + ), patch.object(LinuxRuntime, "_clear_initial_prompt", return_value=None), patch.object( + LinuxRuntime, "send_command", return_value=MagicMock() + ): + LinuxRuntime._start_container("task-image", "task-id", 30, 1) + return captured + + +def test_linux_runtime_uses_engine_dns_by_default(monkeypatch): + captured = _start_runtime(monkeypatch) + + assert "dns" not in captured + + +def test_linux_runtime_passes_trimmed_opt_in_nameservers(monkeypatch): + captured = _start_runtime(monkeypatch, " 1.1.1.1, , 2606:4700:4700::1111 ") + + assert captured["dns"] == ["1.1.1.1", "2606:4700:4700::1111"] \ No newline at end of file