From 237be39064c8b4407ed505f5dca0c39753c5577f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ianar=C3=A9=20S=C3=A9vi?= Date: Tue, 17 Nov 2026 10:34:20 +0100 Subject: [PATCH 1/2] :sparkles: better printing of error messages --- lib/mindee/v2/parsing/error_response.rb | 26 +++++++++++++++++++++++-- spec/v2/parsing/error_response_spec.rb | 21 ++++++++++++++++++++ 2 files changed, 45 insertions(+), 2 deletions(-) create mode 100644 spec/v2/parsing/error_response_spec.rb diff --git a/lib/mindee/v2/parsing/error_response.rb b/lib/mindee/v2/parsing/error_response.rb index cec156101..567530782 100644 --- a/lib/mindee/v2/parsing/error_response.rb +++ b/lib/mindee/v2/parsing/error_response.rb @@ -31,10 +31,32 @@ def initialize(server_response) end end - # String representation. + # To make the error prettier to display. # @return [String] def to_s - "HTTP #{@status} - #{@title} :: #{@code} - #{@detail}" + result = [ + 'Error Details', + '=============', + ":HTTP Status: #{@status}", + ":Title: #{@title}", + ":Code: #{@code}", + ":Detail: #{@detail}", + ] + + if @errors && !@errors.empty? + result << '' + result << 'Error Items' + result << '-----------' + + @errors.each_with_index do |error, i| + result << "**Error #{i + 1}:**" + result << " :Pointer: #{error.pointer}" + result << " :Detail: #{error.detail}" + result << '' if i < @errors.length - 1 + end + end + + "#{result.join("\n")}\n" end # Hash representation diff --git a/spec/v2/parsing/error_response_spec.rb b/spec/v2/parsing/error_response_spec.rb new file mode 100644 index 000000000..4b877f7af --- /dev/null +++ b/spec/v2/parsing/error_response_spec.rb @@ -0,0 +1,21 @@ +# frozen_string_literal: true + +require 'mindee/v2/parsing' +require 'mindee/input/local_response' +require_relative '../../data' + +describe Mindee::V2::Parsing::ErrorResponse do + it 'should load and pretty print an error response' do + local_response = Mindee::Input::LocalResponse.new( + File.join(V2_DATA_DIR, 'errors', 'error_422_invalid_fields.json') + ) + response = local_response.deserialize_response(described_class) + + rst_output = File.read( + File.join(V2_DATA_DIR, 'errors', 'error_422_invalid_fields.rst') + ) + + expect(response).not_to be_nil + expect(response.to_s).to eq(rst_output) + end +end From 2befe92172de67f04811db1b87e763dbb139dc77 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?ianar=C3=A9?= <97107275+ianardee@users.noreply.github.com> Date: Tue, 17 Nov 2026 10:44:17 +0100 Subject: [PATCH 2/2] Add error_item requirement to error_response_spec Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com> --- spec/v2/parsing/error_response_spec.rb | 1 + 1 file changed, 1 insertion(+) diff --git a/spec/v2/parsing/error_response_spec.rb b/spec/v2/parsing/error_response_spec.rb index 4b877f7af..604778b59 100644 --- a/spec/v2/parsing/error_response_spec.rb +++ b/spec/v2/parsing/error_response_spec.rb @@ -1,6 +1,7 @@ # frozen_string_literal: true require 'mindee/v2/parsing' +require 'mindee/v2/parsing/error_item' require 'mindee/input/local_response' require_relative '../../data'