From ed82dbb9086c749e3608db6de2edf98c8c58d1dc Mon Sep 17 00:00:00 2001 From: Dylan Pulver Date: Wed, 18 Nov 2026 11:12:25 -0600 Subject: [PATCH 1/3] Document the URL default get_acis_station_data actually uses The signature is url="https://data.rcc-acis.org/StnData", which is the station endpoint, but the docstring documented the GridData endpoint. The three sibling readers (get_acis_prism, get_acis_nrcc, get_acis_mpe) all default to GridData and document it correctly, so the entry looks copied across from them when the station reader was added. --- pvlib/iotools/acis.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/pvlib/iotools/acis.py b/pvlib/iotools/acis.py index 634af07933..c18ae3b48c 100644 --- a/pvlib/iotools/acis.py +++ b/pvlib/iotools/acis.py @@ -352,7 +352,7 @@ def get_acis_station_data(station, start, end, trace_val=0.001, names where applicable. See variable :const:`VARIABLE_MAP`. trace_val : float, default 0.001 Value to replace "trace" values in the precipitation data - url : str, default: 'https://data.rcc-acis.org/GridData' + url : str, default: 'https://data.rcc-acis.org/StnData' API endpoint URL kwargs: Optional parameters passed to ``requests.post``. From a8a9d206de2971d342d9917f68d75954b154157f Mon Sep 17 00:00:00 2001 From: Dylan Pulver Date: Wed, 18 Nov 2026 11:52:53 -0600 Subject: [PATCH 2/3] Add whatsnew entry for the acis station URL default fix --- docs/sphinx/source/whatsnew/v0.16.2.rst | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/docs/sphinx/source/whatsnew/v0.16.2.rst b/docs/sphinx/source/whatsnew/v0.16.2.rst index 5893d8bf46..0db118d4b6 100644 --- a/docs/sphinx/source/whatsnew/v0.16.2.rst +++ b/docs/sphinx/source/whatsnew/v0.16.2.rst @@ -21,6 +21,9 @@ Bug fixes is scalar (:issue:`2881`, :pull:`2882`) * :py:func:`pvlib.scaling.wvm` no longer returns all NaNs when ``positions`` contains a single site (:issue:`2895`, :pull:`2896`) +* Document the URL default :py:func:`pvlib.iotools.get_acis_station_data` actually + uses. Its docstring named the GridData endpoint; the signature uses StnData. + (:pull:`2950`) Enhancements ~~~~~~~~~~~~ @@ -80,3 +83,4 @@ Contributors * :ghuser:`bfs2021` * :ghuser:`xiajiahang` * Jakub Krasuski (:ghuser:`Blizzeq`) +* Dylan Pulver (:ghuser:`dylanpulver`) From c25cf2f7242be2f17606006f9524dce317665bc8 Mon Sep 17 00:00:00 2001 From: Dylan Pulver Date: Wed, 18 Nov 2026 13:29:06 -0600 Subject: [PATCH 3/3] Apply cwhanse's wording for the whatsnew entry --- docs/sphinx/source/whatsnew/v0.16.2.rst | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/sphinx/source/whatsnew/v0.16.2.rst b/docs/sphinx/source/whatsnew/v0.16.2.rst index 0db118d4b6..fb3ff54f76 100644 --- a/docs/sphinx/source/whatsnew/v0.16.2.rst +++ b/docs/sphinx/source/whatsnew/v0.16.2.rst @@ -22,7 +22,7 @@ Bug fixes * :py:func:`pvlib.scaling.wvm` no longer returns all NaNs when ``positions`` contains a single site (:issue:`2895`, :pull:`2896`) * Document the URL default :py:func:`pvlib.iotools.get_acis_station_data` actually - uses. Its docstring named the GridData endpoint; the signature uses StnData. + uses. Its docstring named the GridData endpoint; should be StnData. (:pull:`2950`) Enhancements