Repository navigation
Examples that build from a fresh clone, checked in CI - #192
Merged
Merged
Conversation
The fresh-clone workflow built only the console examples, with their tests compiled. A web example test that used a class the published packages lack would not have failed it. The Ubuntu job now builds every example module with its tests compiled, after it has saved the data file for the other systems.
…heck One conflict, in AGENTS.md, where rc says how to run the fresh clone check by hand with -ExpectDownload as a switch, and this branch says the Ubuntu job then builds every example module with its tests compiled. Both are kept, this branch's sentence first, then rc's sentence on running the check by hand. The workflow merged with no conflict, and this branch's step still comes after the data file is saved for the other systems.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The problem
Since #175, the tests in
examples/device-detectionimportedTestFileUtilsandTestKeyUtilsfrom device-detection.shared'ssrc/test. A fresh clone builds the examples against the published packages, whose 4.5.130 tests jar has neither class, somvn -pl console -am package -DskipTestsinexamples/device-detectionfailed atGettingStartedOnPremTest.java:[26,51]. #187 (343baac) fixed that build, and rc passes from a fresh clone. Nothing stops the same failure coming back.What the specification says
required-examples.md lines 91 to 97 at d79bbe3b says
The new step guards the build half of that, so an example that cannot build from a fresh clone fails in CI.
The change
f17fd53 adds a step to the Examples from a fresh clone workflow (
.github/workflows/examples-fresh-clone.yml). On Ubuntu it builds every example module, the web examples too, with its tests compiled, against only the published packages, so a test that uses a class the published packages lack fails there. It runs after the asset cache is saved, so the other systems still get the data file, and it does not run the tests, which the pull request build runs.AGENTS.mddescribes the new step.rchas since made-ExpectDownloada switch ofci/run-fresh-clone-example.ps1(#196), so the script runs by hand withpwsh -Fileas AGENTS.md says, and this draft's step does not call the script.The runs
GettingStartedOnPremTest.java:[26,51] cannot find symbol, so the new step does not run there. The new step widens what the workflow builds, to every example module with its tests.ci/run-fresh-clone-example.ps1pass for both products at f17fd53 and at rc 81e3d4a, and every com.51degrees artifact resolved at 4.5.130. At 20f9089 the device-detection build fails atGettingStartedOnPremTest.java:[26,51], and ManualDataUpdateTest, MetadataOnPremTest and OfflineProcessingTest fail the same way.tmp/pr-matrix-192-f17fd53(workflow commit 67e3d14 onrc81e3d4a) built f17fd53, as theSetting 'PullRequestSha'line of its Ubuntu Java 8 job names. Configure, all nine Build and Test jobs (Ubuntu x64 with Java 8, 11, 17 and 21, Ubuntu arm64 with Java 17, and Windows with Java 8, 11, 17 and 21) and Complete passed. macOS was left out of that build. This change touches CI andAGENTS.mdonly, so the workflow's own runs are the tests of what it touches, and the build above is extra.Changes at this head
The previous head, f17fd53, no longer merged into
rc, where #196 had rewritten the same paragraph of AGENTS.md to say how to run the fresh clone check by hand. One commit follows it.rc3bb6e71 in. One conflict, in AGENTS.md, where both sides are kept, this draft's sentence that the Ubuntu job then builds every example module with its tests compiled, followed byrc's sentence on running the check by hand withpwsh -Fileand-ExpectDownload. The workflow merged with no conflict, and this draft's step still comes after the data file is saved for the other systems. The commit adds no test, so it has no red.maven-pmd-plugin3.28.0 to that runner, which the Device Detection job of the same run had resolved, and the job passed when run again. CI script tests run 44463861716 passed on Ubuntu and Windows, and every other check on 9b1fa72 passed.What remains
Nothing in this draft. #148 also changes
.github/workflows/examples-fresh-clone.ymland AGENTS.md, in other lines, and a trial merge of the two heads is clean.Before you upgrade
Nothing changes in the packages. This adds a CI step only.