Repository navigation
Give the released missing property messages again, and share a parameter only when it starts with 51D_ or the Pipeline uses it - #246
Merged
Conversation
Restore the released form of the tests whose behaviour rests on a specification SHOULD, being the missing property messages and a usage sharing filter given None for its query string parameters: - test_engines.py testRestrictedProperty, testRestrictedPropertyIgnoresCase and testMissingPropertyService - the on-premise Device Detection test_devicedetection.py test_excluded_property, test_missing_property_service_not_found_anywhere and test_missing_property_service_not_found_in_current - test_credentials.py test_missing_property_message_names_both_causes - the cloud Device Detection test_cloud.py test_missing_property_service_not_found_anywhere - test_share_usage_evidencekeyfilter.py test_no_parameter_list_shares_every_parameter test_missing_property_reasons.py and test_cloudengine_missing_property.py go, because each of their checks is a message of the missing properties table, which the released messages replace. New tests keep what a MUST requires. In both on-premise packages a property the engine lists, in a data file tier that holds it, raises when the data has no value for it. And share_all_query_string_parameters given as False or True decides whatever the parameter list holds.
The properties specification asks that an implementation SHOULD give the missing properties table's text and SHOULD decide the reason in the table's order. As both are SHOULDs, each engine raises the message it raised in the last release again, so the released tests pass unaltered. That restores the missing property services of the engines, cloud and on-premise packages and AspectData.get to their released form. The one change that stays is the specification's MUST to raise for a missing property. The on-premise Device Detection and IP Intelligence services raise for a property the engine lists in a data file tier that holds it, with the table's message for a property that is not available, where they returned nothing.
… given ShareUsageEvidenceKeyFilter given query_whitelist=None, with share_all_query_string_parameters not given, shares every query string and form parameter, as the released filter did, because no sentence of the specification says how None is read. The option now defaults to None for not given. Given as False, the specification's MUST holds, so only parameters starting 51D_ and those on the list are shared, and given as True every parameter is. The ShareUsage element always gives the option, so it shares as before.
This was referenced Nov 17, 2026
Query string and form parameters are shared only when their names start with 51D_ or a Flow Element of the Pipeline accepts them as evidence, from a GET query string and a POST form body alike, whatever the settings. The deprecated query_whitelist and share_all_query_string_parameters options share nothing more, and the JavaScript Builder counts only for the parameters its specification lists. The filter, list and usage tests that relied on those options, or on every parameter being shared, are updated to the rule. The released test test_default_shares_only_accepted_evidence goes back to its released form.
The usage sharing filter decides a query. key, which carries query string and form parameters alike, before share_all and whatever the configuration. It is shared when its name starts with 51D_ or a Flow Element of the Pipeline accepts it as evidence, so a value such as a password is never sent. The JavaScript Builder passes every parameter so that it can send them back to its callback, so it is asked only about the two parameters its specification lists. query_whitelist and share_all_query_string_parameters are deprecated and have no effect, and are still accepted so that existing code and configuration build.
test_no_parameter_list_shares_every_parameter checks that a list of None, or an empty one, shares only the parameters starting 51D_. It is now test_no_parameter_list_shares_only_51d_parameters. test_the_option_given_decides_whatever_the_list checks that the deprecated share_all_query_string_parameters option, on or off, changes nothing that is shared. It is now test_the_deprecated_option_changes_nothing. Only the names change, and both tests pass as before.
ShareUsageEvidenceKeyFilter took None for share_all_query_string_parameters to mean that the option was not given, so that a parameter list of None could share every parameter. The option now has no effect, so None means nothing and the default is False again, as the filter had on rc. Which evidence is shared does not change.
ben51degrees
pushed a commit
that referenced
this pull request
Nov 19, 2026
PackageTests and its helpers move from test_share_usage_rules.py to the new test_share_usage_packages.py, unchanged. test_share_usage_rules.py is now the same as on rc, so this branch no longer touches the file that #246 rewrites for the 51D_ and used Evidence rule.
ben51degrees
marked this pull request as ready for review
November 19, 2026 20:15
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Some tests from the last release fail when they're run unchanged against
rc. Each of those failures falls into one of three kinds, and the kind decides what this draft does about it.rcchanged the behavior because a specification sentence says MUST, or describes the new behavior directly, the new behavior stays.rc's own test already checks it, and the change is listed under Before you upgrade.rc's copy of that test is restored to match.That leaves two items in this draft.
Nonemeans. That no longer matters, because this draft adds a new usage sharing rule for parameters, and under that rule the list has no effect (Before you upgrade item 5).The rule for query string and form parameters
specifications#191 has merged into the specification's
rc, and every specification link here points atrc's commit d79bbe3b. The rule itself is inusage-sharing-element.mdlines 72 to 78.Lines 100 to 104 cover the options for included query string parameters and for sharing all of them. Both "are deprecated and have no effect", and "setting it MUST NOT change which parameters are shared." Lines 81 to 91 apply the
query.prefix to a GET query string and a POST form body alike. They also say a parameter no Flow Element in the Pipeline accepts, such aspassword, is never shared.Problem
The
testsfolder of each package from the last release,main612aa28, ran unchanged againstrc2373d14 (still the merge base) with no keys. Failures by package were core 1, engines 31, engines_fiftyone 8, cloud request engine 7, 51Did 8 plus 5 files not collected, cloud Device Detection 9, on-premise Device Detection 6, Device Detection examples 6 plus 1 not collected, on-premise IP Intelligence 1, IP Intelligence translation 1, IP Intelligence examples 4, and location 1 file not collected. Add a resource key, putcryptographyand the OWID source on the path for 51Did the way CI installs them, and the only failures left are the behavior changes in the second table.Released tests that fail only for their environment
fiftyone_pipeline_cloudrequestenginetest_cloudengine.pyCloudEngineTeststest_HttpDataSetInException,test_cloud_engine,test_cloud_get_request_with_sequence_evidence,test_cloud_post_request_with_sequence_evidencefiftyone_devicedetection_cloudtest_cloud.pytest_basic_get_cloud,test_cloud_request_origin,test_engine_init_performance,test_missing_property_service_element_not_found,test_pipeline_builder_cloud_engine_init,test_properties_cloudfiftyone_devicedetection_cloudtest_properties.pytest_available_properties,test_value_typestests/51Degrees.csvfiftyone_devicedetection_examplestest_cloudexamples.pytest_cloud_configurator_console,test_cloud_failuretomatch,test_cloud_getting_started_console,test_cloud_metadata_console,test_cloud_nativemodellookup_console,test_cloud_taclookup_console, andtest_cloudgettingstartedweb.py, not collectedfiftyone_ipintelligence_examplestest_examples.pytest_cloud_getallproperties_console,test_cloud_gettingstarted_console,test_cloud_metadata_console,test_cloud_mixed_consolelocationtest_properties51D.py, not collectedfiftyone_pipeline_didtest_creator_context_server.py,test_did_client.py,test_did_client_live.py,test_did_tier_live.py,test_fodid.py, not collectedcryptographyandowidweren't installedrc's own tests fail to collect the same way without themfiftyone_pipeline_didtest_live_cloud.pyCopiesTests.test_every_copy_is_the_same_file, one failure for each of 8 folderslive_cloud.pywithrc's copies in the other test foldersfiftyone_ipintelligence_translationtest_translation.pytest_translations_are_packagedrc's copy, which is the same, fails the same way from the sourceReleased tests that fail because
rcchanged the behaviorrcpull requesttest_setheader.pytest_get_response_header_name_1_SetHeaderbrowserAccept_CH[Identifier]is some string that relates to what this value is for. It MUST NOT have upper-case characters after the first character." set-headers-element.md lines 12 to 17rc's test already checks the new behavior. Item 1test_datafile_update_http.pyUpdateFromMemoryTeststestMemoryDataFileIsRefreshedFromTheBytes,testFileDataFileIsWrittenThenRefreshed,testFailedRefreshIsReportedAndLogged, andCallbackTeststestACallbackErrorOnAnUpdateFromMemoryIsLoggedAndStopsTheCallbacksrc's tests already check this, so they stay. Item 2UpdateFromMemoryTests.testAFailedWriteFromMemoryEndsTheUpdate,FileReplacementTeststestFailedCopyNamesThePath,testNoTemporaryPathIsReportedrc's tests already cover it. Item 2LoggingTeststestAnyOtherStatusNamesTheCode,testConnectionFailureIsError,testFailedRefreshIsError,testIntegrityCheckFailureIsError,testRefusedDownloadIsError,testTheErrorEntryIsWrittenExactly,testTooManyRequestsIsError,DownloadedFileTeststestAFailedTemporaryCopyIsAnyOtherError,testAFailedWriteEndsTheUpdateAndLeavesTheEngineAlone,CallbackTeststestACallbackErrorOnAProgrammaticCheckIsLoggedAndStopsTheCallbacks,testAConnectionFailureKeepsPolling,LicenceKeyTeststestEachFailedAnswerShowsOnlyTheMaskedKey,testFailedConnectionShowsOnlyTheMaskedKey,ContentTeststestCorruptCompressedContentIsAnErrorAndCheckedAgainLater,testFailedMd5CheckOnStartUpIsNotRepeatedAtOnce, andtest_licence_key_masking.pyUpdateServiceLogTeststest_a_callback_error_logs_only_the_masked_key,test_a_failed_request_logs_only_the_masked_key,test_no_message_holds_the_key,test_the_masked_url_is_in_the_messageupdate_data_file, raises its failure to the caller after reporting it, and logs nothing. Each test called it and read the logrc's tests read the log from a polled check instead, which still logs. Item 3test_datafile_update_service.pyFileSystemWatcherTeststestFileSystemWatcherFailedRefreshUsesTheTableMessage,testFileSystemWatcherKeepsWatchingAfterFailedRefresh, and the text ofLoggingTests.testFailedRefreshIsErrorrc's tests expect "after 10 tries", and the draft leaves them. Item 4test_usage.pytest_default_shares_only_accepted_evidenceandtest_share_usage_accepts_no_evidence.pytest_the_web_request_is_shared_by_the_same_rules51D_or the Pipeline uses it, where #201 shared every one by defaultrc's copy of the first is restored from the releasetest_usage.pytest_share_all(its cookie part),test_share_usage_evidencekeyfilter.pytest_share_all, andtest_share_usage_accepts_no_evidence.pytest_the_method_is_shared_and_the_path_and_cookie_header_are_not51D_is never shared, even when all evidence iscookie.and whose field does not start with51D_." lines 66 to 70rc's tests checking that such a cookie isn't shared. Item 6test_usage.pytest_empty_query_whitelist,test_parameter_names_with_dotsand the parameter part oftest_share_all, andtest_share_usage_evidencekeyfilter.pytest_field_is_everything_after_the_first_dot,test_lists_ignore_case,test_naming_a_parameter_does_not_share_the_query_string,test_never_shared_keys_match_whole_parts,test_no_parameter_list_shares_every_parameterand the parameter part oftest_share_allquery_whitelistandshare_all_query_string_parametersno longer share a parameter, andquery_whitelist=Noneno longer shares every onerc's copies now follow the rule, andtest_no_parameter_list_shares_every_parameteris renamedtest_no_parameter_list_shares_only_51d_parameters. Item 5test_credentials.pytest_licence_key_discovers_properties_with_the_key_in_the_bodyrc's test picks out the properties request by its address. Item 7test_cloudresponse.pytest_validate_error_handling_invalid_resourceKeyerrorslist is the message, without the list's brackets and quoteserrorsProperty in the JSON response contains an entry, then it will need to be parsed and the text used as the message for the thrown error." lines 480 to 482. The SHOULD of line 478 is about whether to throw, which both releases dorc's expected message is already the new one. Item 8test_devicedetection.pytest_validate_data_true,test_validate_data_falserc's tests already check the new behavior, and the draft doesn't touch them. Item 9test_update_matched_useragent.pytest_turned_off_leaves_user_agents_empty[]whenupdate_matched_useragentis off, where it was[""][], "Populated when the Update Matched User Agent configuration option is on" line 473rc's test expects[]. Item 10test_ipintelligence.pytest_missing_licence_keyrcreplaced the test withtest_licence_key_rule.py, which stays. Item 11test_did_client.pyRedeemTeststest_a_factor_that_was_not_compared_is_still_none,test_redeemed_with_factors,test_to_dict_is_the_cloud_shapenullfactor in a redeem answer isFactorResult.MISMATCH, where it wasNonerc's tests expectFactorResult.MISMATCH. Item 12test_engines.pytestRestrictedProperty,testRestrictedPropertyIgnoresCase,testMissingPropertyService, on-premise Device Detectiontest_devicedetection.pytest_excluded_property,test_missing_property_service_not_found_anywhere,test_missing_property_service_not_found_in_current, cloud request enginetest_credentials.pytest_missing_property_message_names_both_causes, and, with a key, cloud Device Detectiontest_cloud.pytest_missing_property_service_not_found_anywhereThe change
fiftyone_pipeline_engines,fiftyone_pipeline_cloudrequestengine,fiftyone_devicedetection_onpremiseandfiftyone_ipintelligence_onpremise, andAspectData.get, go back to the release's code, so each raises the message it raised in the release.HardwareProfileDatainfiftyone_devicedetection_cloudcame in onrcand isn't onmain, so it now uses the missing property service that cloud data had in the release, fromclouddata.py. What stays from Give a missing property's reason in the specification's order #221 is the MUST that "the system MUST throw an error/exception with a message explaining why the Property is not available" (properties.md lines 116 to 118). In the release, the on-premise services returned nothing for a property the engine lists in a data file tier that holds it. They now raise for a property that isn't available, asrcdoes.None, c781d95, madequery_whitelist=Nonemean what it meant in the release. After item 5 the list has no effect at all, so c781d95 no longer changes anything.test_missing_property_reasons.pyandtest_cloudengine_missing_property.pyare deleted, because every check in them is a message from the table, and the code they tested goes too. New tests cover the MUST that stays.test_missing_property_raises.pyin both on-premise packages checks that a listed property of the data file's tier raises. It passes onrcand fails against the services as released, which return nothing.test_the_deprecated_option_changes_nothingchecks that the option, given asFalseorTrue, changes nothing.test_share_usage_rules.pychecks that a51D_parameter and one a Flow Element of the Pipeline uses are shared. It also checks thatpasswordand other names never are, under any setting ofshare_all,query_whitelistorshare_all_query_string_parameters, whether set in code or in a configuration file. The filter, list and usage tests that relied on those options now follow the rule, andrc's copy oftest_default_shares_only_accepted_evidenceis the release's version again.ShareUsageEvidenceKeyFilternow decides aquery.key before it looks atshare_all, whatever the configuration says. It shares the key only when the name starts51D_or a Flow Element of the Pipeline accepts it, andShareUsagehands the filter the Flow Data's Pipeline so it can ask. The two options stay as deprecated names that do nothing. The JavaScript Builder needs care here. Its filter passes every query string parameter so it can send them back to its callback, but its specification lists onlyquery.fod-js-object-nameandquery.fod-js-enable-cookiesas accepted Evidence (javascript-builder.md lines 16 to 21). Usage sharing asks the JavaScript Builder about those two only, because otherwise every parameter of a web Pipeline,passwordincluded, would count as used.test_no_parameter_list_shares_every_parameternow checks that a list ofNone, or an empty one, shares only51D_parameters, so it's renamedtest_no_parameter_list_shares_only_51d_parameters.test_the_option_given_decides_whatever_the_list, which this draft added, becomestest_the_deprecated_option_changes_nothing, since that's what it checks.ShareUsageEvidenceKeyFilterdefaultsshare_all_query_string_parameterstoFalseagain, as onrc, in place of theNonethat c781d95 gave it.ShareUsagealways passes its own value, so what's shared doesn't change.Red and green
Each run built the named commit with one temporary workflow commit on top, on Ubuntu and Windows with Python 3.10 to 3.14, which is ten jobs.
rc2373d14. Every job failed on the same seven restored tests and nothing else. Three are intest_engines.py("3 failed, 117 passed"), three intest_devicedetection.py("3 failed, 101 passed"), and the seventh istest_no_parameter_list_shares_every_parameter("1 failed, 121 passed"). A unit stage failure ends the job, and the restoredtest_credentials.pytest and the cloudtest_cloud.pytest belong to the integration stage, so they didn't run there. They're red in Local counts instead.fiftyone_pipeline_engines_fiftyone. The Ubuntu jobs for 3.11, 3.12 and 3.13 stopped before the tests whenpip installfailed.fiftyone_pipeline_engines_fiftyone123 passed,fiftyone_pipeline_engines120, the Cloud Request Engine 144 passed and 2 skipped, on-premise Device Detection 104 and on-premise IP Intelligence 79.test_missing_property_raises.pyin both on-premise packages fails with "Exception not raised" against each package'sswig_data.pyfrom the release, and passes onrcand on the head.dc6e95e and 1504f3e don't add a test that fails first, since neither changes what's shared.
Local counts
These runs took each package's
testsfolder frommain612aa28, with no edits, and ran it againstrc2373d14 and against the draft, comparing failing tests by name. Runs with a key set a resource key, and the 51Did runs also hadcryptographyand the OWID source on the path. Apart from the filter tests the parameter rule changes (Before you upgrade item 5), nothing that passes onrcfails on the head.rc, no keyrc, with a keyrcfiftyone_pipeline_corefiftyone_pipeline_enginestestMissingPropertyService,testRestrictedProperty,testRestrictedPropertyIgnoresCasefiftyone_pipeline_engines_fiftyonetest_default_shares_only_accepted_evidence,test_the_web_request_is_shared_by_the_same_rulesfiftyone_pipeline_cloudrequestenginetest_missing_property_message_names_both_causesfiftyone_pipeline_translationfiftyone_pipeline_didfiftyone_devicedetection_cloudtest_missing_property_service_not_found_anywhere, with a keyfiftyone_devicedetection_onpremisetest_excluded_property,test_missing_property_service_not_found_anywhere,test_missing_property_service_not_found_in_currentfiftyone_devicedetection_examplesfiftyone_ipintelligence_sharedfiftyone_ipintelligence_cloudfiftyone_ipintelligence_onpremisefiftyone_ipintelligence_translationfiftyone_ipintelligence_exampleslocationWhat still fails on the head is the environment failures and the MUST changes in the tables above.
Most rows date from a run before dc6e95e and 1504f3e, which only touch
fiftyone_pipeline_engines_fiftyone. The four pipeline package rows were run again on Windows with Python 3.12.10 and no key, againstrc2373d14 and 1504f3e. They gave the counts in the table, with the same failing tests by name as before. At 1504f3e, the package's own tests gave 123 passed forfiftyone_pipeline_engines_fiftyone.What remains
test_validate_error_handling_invalid_resourceKeydepends on "the text used as the message" in lines 480 to 482. The draft reads that as a plain statement, because the SHOULD of line 478 is about throwing, not about the message. If it's read as part of that SHOULD instead, the release's message, brackets and quotes included, would come back for one entry.query.key, usage sharing asks each Flow Element's evidence key filter in turn. Each Flow Element keeps its filter, so the cost is small and the loop stays as it is.share_all_query_string_parameters=False, a settingrcadded that now does nothing. They'retest_the_web_request_is_shared_by_the_same_rulesintest_share_usage_accepts_no_evidence.py, whose comment about that option is no longer true, andtest_empty_query_whitelistintest_usage.py. The first also passes as the release has it. Putting both back without the option would only change tests.Before you upgrade
Every item here changes what the last release did, and each one is required by a MUST in the specification or by a sentence that describes the new behavior directly. Items 5 and 13 are new in this draft. The rest came in with the
rcpull request named in parentheses, and the draft keeps them.Set Header names (Add the web elements only when the caller has not, and read every valid Set Header name #140). set-headers-element.md lines 12 to 17 only rule out upper-case characters after the first one. So
SetHeaderElement.get_response_header_namenow reads a name whose identifier starts with a lower-case letter, such asSetHeaderbrowserAccept-CH, as the headerAccept-CH, where it used to raise. Code that relied on the error gets the header name instead.Updates from memory (Give the result of an update from memory to its caller alone #169 and Refresh the engine from the bytes given when an update from memory cannot write the data file #175).
update_from_memoryreports nothing to the update complete callbacks, and returns success or raisesDataUpdateExceptionwithout logging it. Data that can't be written to the data file is logged as a warning, and the engine is still refreshed from it. That's what data-updates.md lines 321 to 323, 379 to 383 and 518 ask for. Read the resultupdate_from_memoryreturns, catch its error, and don't wait for a callback.Programmatic checks (Raise a failed programmatic update check to its caller #188). Under data-updates.md lines 356 and 357, 484 to 486, and 499 and 500,
update_data_filereports a failed check to the update complete callbacks and then raises it to the caller, asDataUpdateExceptionor as the error itself, logging nothing. An error a callback raises during the check reaches the caller too. Where code read the log or relied on the call returning, catch the error.Refresh tries (Try a refresh 10 times and wait for a watched file, as .NET does #220). A failed refresh from the data file is tried 10 times, 0.2 seconds apart, and the message says "after 10 tries", which is the message data-updates.md lines 488 to 490 and 516 call for. Code that matched "after 1 tries" should match "after 10 tries", and a failed refresh now takes about two seconds longer to report.
Query string and form parameters (this draft).
ShareUsageshares a query string or form parameter, from a GET or a POST alike, only when its name starts51D_or a Flow Element of the Pipeline accepts it as evidence. That holds whatever the configuration, even withshare_all=True.query_whitelistandshare_all_query_string_parametersare deprecated and do nothing, andquery_whitelist=Noneno longer shares every parameter. The rule comes from usage-sharing-element.md lines 72 to 78, and lines 100 to 104 deprecate the two options. These tests from the release change:test_usage.py:test_empty_query_whitelist,test_parameter_names_with_dots, and the parameter part oftest_share_all, which expected<query Name="campaign">campaign value</query>to be shared.test_share_usage_evidencekeyfilter.py:test_field_is_everything_after_the_first_dot,test_lists_ignore_case,test_naming_a_parameter_does_not_share_the_query_string,test_never_shared_keys_match_whole_parts, the parameter part oftest_share_all, andtest_no_parameter_list_shares_every_parameter, nowtest_no_parameter_list_shares_only_51d_parameters.If you want a parameter shared, its name has to start with
51D_or it has to be evidence a Flow Element of the Pipeline accepts. Removequery_whitelistandshare_all_query_string_parameterswhen convenient, since they do nothing.Cookies never shared (Share every query value by default, and no cookie but 51D_ ones #201). usage-sharing-element.md lines 66 to 70 rule out sharing a cookie whose name doesn't start
51D_, even withshare_all=True, and no setting can share one now. The session cookie is still read fortrack_session.Discovery when built (Discover the cloud Properties and Evidence keys when the Cloud Request Engine is built #147). Constructing a
CloudRequestEnginemakes theaccessiblePropertiesandevidencekeysrequests, and a key the service refuses raisesCloudRequestExceptionfrom the constructor. cloud-request-engine.md lines 245 to 248 say the engine must attempt both discovery requests when it's built. Expect both requests, and the error, when the engine is built rather than on first use.Cloud error messages (Raise each entry of the cloud service's errors list as its own error #204). Following cloud-request-engine.md lines 480 to 482, one entry of the cloud service's
errorslist becomes the message as plain text, without the list's brackets and quotes. Code that matched'["in the message should match the text alone.Match metric metadata (Give the match metric Properties the specification's metadata, and list each matched User-Agent once #145). The match metric Properties have the category
Device Metricsand the componentMetrics, where they hadDevice metricsandMatch Metrics, because device-detection-on-premise.md lines 452 to 465 set their metadata that way. Compare against the new names.UserAgents when not recorded (Give UserAgents as an empty list when the option is off, and send no usage data from the web example test #168). With
update_matched_useragent=False, UserAgents is[], where it was[""]. That's the default device-detection-on-premise.md line 473 gives it. Expect an empty list.Licence keys (Need a licence key only for the updates that download #136). data-updates.md lines 114 to 116 need a licence key only for the mechanisms that download. An on-premise Device Detection or IP Intelligence engine now builds with no licence key when nothing downloads, where it refused with "licence key is required". One with
auto_updateorupdate_on_starton, the Distributor's update URL and no key refuses to build, with a message naming those options. Give a key or turn those options off, and don't expect the refusal when nothing downloads.51Did factors (Read a null 51Did factor as a Mismatch, and refuse a short Payload for its version #141). A
nullfactor in a redeem answer isFactorResult.MISMATCH, andto_dict()writes"mismatch"for it, where it wasNone. package-surface.md lines 117 to 121 ask for a factor word the package doesn't know to be reported as a Mismatch. Code that tested a factoris Noneshould test forFactorResult.MISMATCH.A listed on-premise property with no value (this draft). On-premise Device Detection and IP Intelligence data now raise for a property the engine lists in a data file tier that holds it, when the data has no value for it, where
getreturnedNone. properties.md lines 116 to 118 say a Property that isn't available must raise an error that explains why. Catch the error where code readNone.