Repository navigation
Conversation
|
|
Signed-off-by: Stanislav Romanov <stasromanov801@gmail.com>
tirlarim
force-pushed
the
codex/fix-ios-system-monitor
branch
from
November 4, 2026 09:00
7082db0 to
9fd1861
Compare
tirlarim
marked this pull request as ready for review
November 4, 2026 09:09
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
iOS defines
__APPLE__, soSystemMonitor.cppselects the macOS backend and fails to compile against the iPhoneOS SDK atIOKit/graphics/IOGraphicsLib.h.TargetConditionals.hexplicitly and select the macOS backend only whenTARGET_OS_OSXis true. iOS uses the existing empty monitor implementation.CMAKE_SYSTEM_NAMEisDarwin), in both the library and CPU tests.Fixes #2362.
Validation
Tested with Apple Clang 21.0.0 and the Xcode 27.0 SDKs on Apple Silicon.
IOGraphicsLib.herror by cross-compiling the originalSystemMonitor.cppfor iOS.SystemMonitor.cppandConfig_tests.cppto arm64 object files for both iOS 27.0 devices and the iOS 27.0 simulator.RelWithDebInfo, with SIMD disabled. Confirmed the macOS backend and desktop framework linkage are retained.ctest --test-dir build/codex-macos-apple --output-on-failure:test_utils_execpassed; 1173 of 1175 CPU tests passed. The two numerical tolerance failures below also occur on the unmodifiedmaincommit (22dd9c4) using the same build configuration:OpOptimizers/gamma_comp_test2GammaOpCPU/apply_moncurve_mirror_style_fwdConfigCPU test group separately; all tests passed, including the virtual display tests.git diff --checkpassed.The iOS checks compile the affected translation units; a complete iOS library build and device execution have not been performed.