Repository navigation
Conversation
The reader unconditionally applied the yuv_to_rgb conversion to all OPJ_CLRSPC_SYCC tagged images. The conversion assumes three samples per pixel, so a 1-channel image tagged sYCC read and wrote two samples past the end of every scanline buffer. Solution: Only do the yuv_to_rgb conversion if channels >= 3. A lone channel is decoded as plain luma. This matches the behavior of OpenJPEG's own reference decoder. It's a one-line code fix, and all the rest of the changes in this patch are tests and documenting what went wrong. Assisted-by: Claude Code / claude-opus-5-5 Signed-off-by: Larry Gritz <lg@larrygritz.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The reader unconditionally applied the yuv_to_rgb conversion to all OPJ_CLRSPC_SYCC tagged images. The conversion assumes three samples per pixel, so a 1-channel image tagged sYCC read and wrote two samples past the end of every scanline buffer.
Solution: Only do the yuv_to_rgb conversion if channels >= 3. A lone channel is decoded as plain luma. This matches the behavior of OpenJPEG's own reference decoder.
It's a one-line code fix, and all the rest of the changes in this patch are tests and documenting what went wrong.
Found by Anthropic using Claude and manually validated by Ada Logics.
Assisted-by: Claude Code / claude-opus-5-5