Repository navigation
fix(raw): use std::generic_category() instead of strerror_r - #5637
Merged
Merged
Conversation
strerror_r is POSIX only, so the raw plugin fails to build on Windows. Windows CI didn't catch this because it doesn't install LibRaw, so the raw plugin is never compiled there. Use std::generic_category().message() instead, which works everywhere. Assisted-by: Claude Code / Claude Opus 5.5 Signed-off-by: Jinnie Kim <jinhgkim@gmail.com>
Collaborator
|
How did it work in our CI? |
lgritz
approved these changes
Oct 30, 2026
Collaborator
|
Oh, I see, no libraw, so this didn't need to build. Got it. |
lgritz
merged commit Oct 30, 2026
0008a6f
into
AcademySoftwareFoundation:main
56 of 58 checks passed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5636.
strerror_r is POSIX only, so the raw plugin fails to build on Windows. Windows CI didn't catch this because it doesn't install LibRaw, so the raw plugin is never compiled there. Use std::generic_category().message() instead, which works everywhere.
Assisted-by: Claude Code / Claude Opus 5.5