Repository navigation
build(server): advance aw-server-rust pin so the Android app ships the 16-locale frontend - #377
Conversation
…cale frontend The aw-android build consumes the aw-server-rust gitlink, which in turn pins aw-webui. The current pin 69e0ac4d carries aw-webui d6e9d707 (six locales). Advance to 8c15470 (ActivityWatch/aw-server-rust#829), whose aw-webui pin is d7d45cda with all 16 registered languages (including Arabic, Urdu, Swahili) and the single sorted endonym map. Git-Session-Id: c98a97d0-b160-44e5-8d84-e327e8d7a8b3
[Medium impact] The pin update appears safe to merge; no blocking issue was found. SummaryUpdates the
Reviews (2) · Last reviewed commit: "build(server): re-point aw-server-rust p..." · Reviewed by Greptile |
|
Keeping this draft until ActivityWatch/aw-server-rust#829 merges; that dependency is still open. Greptile found no blocking issue (5/5), and the Android server build is still running. No pin change or CI rerun is needed now. |
|
CI evidence on this head: `Build aw-server-rust` passed (8m49s) and `Test` passed (3m26s). That job is the one that matters here: it checks out the pinned `aw-server-rust` submodule and runs `make --directory=aw-server-rust/aw-webui build` (`Makefile:290`), so it proves both that the `8c15470` submodule fetch resolves and that the 16-locale frontend (aw-webui `d7d45cda`) compiles in the Android build. Greptile is 5/5 with no findings. Still outstanding, and unchanged: the remaining CI jobs (E2E, release-variant smoke), an installed-WebView check on a real device, and a published Play Store build — none of which this PR claims. |
…n master Same tree as 8c15470 (the PR head); the merged commit is on aw-server-rust master. Git-Session-Id: b82641f6-9b06-44c8-85ad-3332b944a626
|
ActivityWatch/aw-server-rust#829 merged as |
🤖 AI code reviewNot reviewedConfidence N/A Not scored — this diff moves a submodule pointer and contains no source to assess. Treat it as not reviewed, not as approved. ℹ️ Submodule pointer change only — not reviewed. This diff moves a submodule SHA and contains no source changes, so there is nothing here for me to assess. Whether the bump is safe depends on the submodule's commit range, which this diff does not include. Treat this as not reviewed, not as approved. Reviewed Maintainer commands
|
Why
The Android app builds its web UI from the
aw-server-rustgitlink, which inturn pins
aw-webui:The current pin is
69e0ac4d, whoseaw-webuipin isd6e9d707— the oldsix-language registry (
en,uk,de,ru,zh-CN,sv). The Play Storereview that started the locale work asked for Arabic, and the frontend now has
16 registered languages (Arabic, Urdu, Swahili, Bengali, Indonesian,
Japanese, Hindi, French, Spanish, Brazilian Portuguese …) at the verified
frontend revision
d7d45cda.Change
Advance only the
aw-server-rustsubmodule pointer,69e0ac4d→96c64e58(the ActivityWatch/aw-server-rust#829 merge commit on master; same tree as the PR head8c15470). No Gradle, Kotlin, Rust or resource changes.8c15470is the reviewed head of [ActivityWatch/aw-server-rust#829], whoseaw-webuipin isd7d45cda. That aw-server-rust revision passed its own CI(Android, macOS, Windows, Ubuntu, clippy, format) with this exact pin.
Status
ActivityWatch/aw-server-rust#829 merged 2026-10-26 as
96c64e58, a descendant of the current pin69e0ac4d(4 ahead, 0 behind). The pin now points at that master commit, so this PR is ready.Verification
aw-webuiatd7d45cda: locale key/placeholder/order checks pass, 16registered + picker locales, 1,127 Jest tests pass (21 skipped), production
webpack build passes, and isolated real-browser checks covered every picker
selection, server/localStorage persistence and reload, plus Arabic/Urdu
direction switching at 1280px and 390px
(Complete i18n suite aw-webui#1137)
here; CI on this PR is the build check. Play Store availability is not
claimed by this PR