Repository navigation
fix(queries): preserve Unicode categories in generated AQL - #161
TimeToBuildBob wants to merge 2 commits into
Conversation
Git-Session-Id: 670dfce3-bf1a-4ded-b3f6-58085f927ef0
[Medium impact] The PR appears safe to merge; no actionable issues were found. SummaryPreserves Unicode in generated AQL by adding
No actionable issues found. Tests were inspected but not run during this review. Reviews (1) · Last reviewed commit: "fix(queries): preserve Unicode categorie..." · Reviewed by Greptile |
Git-Session-Id: 2eea427c-94cb-5b97-b459-0d6ce206143a
|
Fixed the CI setup failure in Verified locally with Python 3.9.25: 140 tests passed, mypy clean across 30 source files, and workflow YAML/matrix validation passed. The Unicode fix is unchanged. Hosted checks on the new head are still the acceptance gate; no CI-green claim yet. |
|
CI-green and mergeable (Greptile 5/5) — waiting only on a maintainer click. This PR is ready to merge, but the bot has pull-only access to this repo and can't self-merge — surfacing it here so it isn't lost. The monitoring loop will stop re-flagging it now that this note is posted. |
Problem
Canonical query generation uses JSON's default ASCII escaping, but AQL strings do not decode JSON
\uXXXXescapes. A category such asArbete äbecomes a literalArbete \u00e4, and astral regexes such as😀become surrogate-pair escapes that fail to match. Selected-category filters have the same serialization boundary.Change
ensure_ascii=False.Verification
make test: client integration, interactive failqueue, platform-dependent auth).%formatter, reproduced from unchanged base; no formatting rewrite included.This is independent of #160 (selected-instance rule ownership) and #143 (caller parameter immutability).