Repository navigation
Read X-Original-Host in the RFC 9421 verifier - #3966
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #
Proposed changes:
X-Original-Hostfirst for@authority,@target-uriand thehostfield, the same way the Draft Cavage verifier already does. Before, sites behind a proxy that rewritesHostcould not verify RFC 9421 signatures.X-Original-Hostis ignored, thenHosthas to name this site, as before (Only verify signatures made out to this site #3964).Other information:
@target-uristill takes the scheme fromis_ssl(). Behind a proxy that terminates TLS, WordPress has to know about HTTPS (for example viaX-Forwarded-Protoor$_SERVER['HTTPS']), otherwise the scheme does not match. That is WordPress configuration, not part of this change.Testing instructions:
vendor/bin/phpunit --filter 'rfc9421_accepts_our_own_original_host|rfc9421_rejects_a_foreign_original_host'internal.localwithX-Original-Hostset to this site, and expects it to verify. Without the change it fails.Changelog entry
Changelog Entry Details
Significance
Type
Message