Skip to content

Direct pending reply searches to moderation - #3985

Merged
pfefferle merged 1 commit into
trunkfrom
fix/search-pending-replies
Oct 28, 2026
Merged

pfefferle merged 1 commit into
trunkfrom
fix/search-pending-replies

Conversation

@pfefferle

@pfefferle pfefferle commented Oct 28, 2026 •

Copy link
Copy Markdown
Member

Follow-up to #3970.

Proposed changes:

  • Since Leave moderation alone when searching for a reply #3970, a search no longer approves a reply it finds. A pending reply does not render on the front end, so the redirect to get_comment_link() ended on a dead link.
  • If the reply is not approved and the user can moderate comments, the search now goes to comment.php?action=editcomment&c=ID. Admin::edit_comment() already forwards received replies from there to their moderation view.
  • Approved replies keep their front-end link, including replies that were auto-approved because the author had a previously approved comment.

Other information:

  • Have you written new tests for your changes, if applicable?

Authors who can moderate replies on their own post still get the front-end link. edit_comment is not usable on the front end for received comments, and I wanted to keep this small.

The unreleased changelog entry of #3970 covers this.

Testing instructions:

  • Run npm run env-test -- --filter=Test_Search.
  • As an editor, search for the URL of a pending ActivityPub reply on the Comments screen or the front end. You should land on the pending comments, and the reply should still be pending.
  • Repeat with an approved reply, which should open on the front end.

Changelog entry

  • Automatically create a changelog entry from the details below.
Changelog Entry Details

Significance

  • Patch
  • Minor
  • Major

Type

  • Added - for new features
  • Changed - for changes in existing functionality
  • Deprecated - for soon-to-be removed features
  • Removed - for now removed features
  • Fixed - for any bug fixes
  • Security - in case of vulnerabilities

Message

@pfefferle pfefferle added Bug Something isn't working Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. [Tests] Includes Tests labels Oct 28, 2026
@pfefferle pfefferle self-assigned this Oct 28, 2026
@pfefferle
pfefferle requested a review from a team October 28, 2026 20:26
@pfefferle
pfefferle force-pushed the fix/search-pending-replies branch 2 times, most recently from 1006402 to 22c1726 Compare October 28, 2026 20:52
@pfefferle
pfefferle force-pushed the fix/search-pending-replies branch from 22c1726 to 124d4ec Compare October 28, 2026 21:04
@pfefferle
pfefferle merged commit e2fbcae into trunk Oct 28, 2026
13 checks passed
@pfefferle
pfefferle deleted the fix/search-pending-replies branch October 28, 2026 21:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Bug Something isn't working Skip Changelog Disables the "Changelog Updated" action for PRs where changelog entries are not necessary. [Tests] Includes Tests

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant