Repository navigation
fix: let MATP holders unstake while their milestone is pending - #127
Merged
Merged
Conversation
The withdrawal actions disabled both initiate and finalize unstake for any MATP whose milestone was not Succeeded, with the message "Withdrawals require milestone to be achieved". The contracts have no such rule. The milestone gates claiming, not unstaking: MATPCore.getClaimable returns 0 unless the milestone is Succeeded. ATPWithdrawableStaker.initiateWithdraw, by contrast, only requires the ATP's operator, and the unstaked tokens go back to the MATP, not to the beneficiary. Finalize is permissionless on the rollup. Simulating initiateWithdraw on Sepolia, from the beneficiary of an MATP with a pending milestone, succeeds. A Failed milestone is the one case that does block the beneficiary. The MATP then reports the revoker as operator, so the beneficiary's initiateWithdraw would revert. Initiate is now gated on that alone, with a message that says so. Finalize is not gated at all.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The ATP withdrawal actions blocked initiate and finalize unstake for any MATP whose milestone wasn't
Succeeded, with the message "Withdrawals require milestone to be achieved". The contracts have no such rule.What the contracts do
ATPWithdrawableStaker.initiateWithdrawonly requires the ATP operator. The stake returns to the MATP, not to the beneficiary.Rollup.finalizeWithdrawis permissionless.MATPCore.getClaimablereturns 0 unless the milestone isSucceeded.I simulated
initiateWithdrawfrom the beneficiary of a testnet MATP whose milestone is still pending, and it succeeds.Change
canWithdrawWithMilestone(Succeeded only) is replaced bycanUnstakeWithMilestone(anything but Failed). Its doc comment states the claim/unstake distinction.Checks
tsc -bpasses.eslintpasses on the three changed files.