Repository navigation
[CosmosDB] Preserve computed properties when updating SQL containers - #10509
Open
pjohari-ms wants to merge 1 commit into
Open
pjohari-ms wants to merge 1 commit into
pjohari-ms wants to merge 1 commit into
Conversation
Keep existing computed-property definitions in replacement container requests so indexing-policy and other updates do not inadvertently delete them. Add request-serialization regression tests and release notes for cosmosdb-preview 1.7.2. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
|
Azure Pipelines: There may be pipelines that require an authorized user to comment /azp run to run. |
microsoft-github-policy-service
Bot
requested a review
from Yong Zhang (yonzhan)
October 22, 2026 21:28
microsoft-github-policy-service
Bot
added
CosmosDB
Auto-Assign
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The narrowly scoped fix matches the SDK contract and includes focused regression coverage, with no blocking issues identified.
No open issues 🎉
What changed in this PR
Preserves existing computed properties when az cosmosdb sql container update builds a replacement request, preventing unrelated updates from deleting those definitions.
Changes:
- Copies computed properties from the existing container into the update request.
- Adds serialization regression tests for indexing and TTL updates, including absent and empty computed properties.
- Updates the extension version and release notes to 1.7.2.
| File | Description |
|---|---|
src/cosmosdb-preview/setup.py |
Bumps the extension version to 1.7.2. |
src/cosmosdb-preview/HISTORY.rst |
Documents the computed-property preservation fix. |
src/cosmosdb-preview/azext_cosmosdb_preview/tests/latest/test_cosmosdb_sql_container_update.py |
Adds regression coverage for serialized update requests. |
src/cosmosdb-preview/azext_cosmosdb_preview/custom.py |
Preserves existing computed properties in container updates. |
Review effort: Balanced
Member
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
3 tasks done
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Keep existing computed-property definitions in replacement container requests so indexing-policy and other updates do not inadvertently delete them. Add request-serialization regression tests and release notes for cosmosdb-preview 1.7.2.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.