Repository navigation
Nexus Identity CLI update to 1.0.0b7 - #10515
Open
idanielsteven wants to merge 4 commits into
Open
idanielsteven wants to merge 4 commits into
idanielsteven wants to merge 4 commits into
Conversation
microsoft-github-policy-service
Bot
added
the
customer-reported
Contributor
|
Thank you for your contribution idanielsteven! We will review the pull request and get back to you soon. |
Contributor
There was a problem hiding this comment.
🔵 Needs a closer look
Native Windows and WOW64 behavior needs platform-specific validation, and the new regression suite has an unresolved test-discovery issue.
1 open issue
What changed in this PR
Updates Nexus Identity CLI to 1.0.0b7, improving Windows OpenSSH discovery and stopping processing when SSH key generation fails.
Changes:
- Resolves Windows
ssh-keygenfrom supported installation paths, including native installations accessed by 32-bit Azure CLI. - Stops before reading or uploading a public key when generation fails.
- Adds regression tests, prerequisite documentation, and release notes.
| File | Description |
|---|---|
src/nexusidentity/setup.py |
Bumps the extension version to 1.0.0b7. |
src/nexusidentity/README.md |
Documents OpenSSH prerequisites and discovery behavior. |
src/nexusidentity/HISTORY.rst |
Adds release notes for the update. |
src/nexusidentity/azext_nexusidentity/tests/unit/test_key_generation.py |
Adds discovery and key-generation regression tests. |
src/nexusidentity/azext_nexusidentity/tests/latest/test_nexusidentity_scenario.py |
Cleans up a scenario docstring. |
src/nexusidentity/azext_nexusidentity/custom.py |
Uses the Windows resolver and handles generation failures. |
src/nexusidentity/azext_nexusidentity/_ssh_keygen.py |
Implements Windows installation and process-architecture discovery. |
Review effort: Balanced
Collaborator
|
/azp run |
|
Azure Pipelines: Successfully started running 2 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation —⚠️ Review suggested
This PR adds warning or check suppressions. Fix the underlying warning where possible and justify each remaining suppression in a code comment or the PR description.
src/nexusidentity/azext_nexusidentity/tests/unit/test_key_generation.py@unittest.skipUnless(sys.platform.startswith("win"), "Requires Windows APIs")Nexus Identity CLI update to 1.0.0b7
aaz: n/a
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install azdevrequired)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.