[robyww]

Firefly-1960: Hips Extraction

• add cube (drill), line, and point extract
• add cube extract
• added PlotViewUtil.js and some ExtracxtionUIUtil.js test
• fixed a bug in rotation checks

Testing

• https://firefly-1960-hips-extract.irsakubedev.ipac.caltech.edu/firefly
• load HiPS
  • cube with fits: https://irsadev.ipac.caltech.edu/data/hips/SPHEREx/spherex_allsky_cube_alpha1
  • normal with fits: PanSTARRS DR1 z
• try extraction
  normal: points or line
  cube: points, line, z-axis

[lrebull]

huh. Well, it seems to work for SPHEREx.
pan stars is a totally different beast. All i get from the extractions are zeros. i never get anythign else, even if i zoom in really far. tried both z and y. am i supposed to get anything other than 0?

[robyww]

@lrebull I missed this during testing. I mostly tested the spherex. The extraction is truncating the values to integers. I will see what is going on.

[lrebull]

i agree it is working now!

[kpuriIpac]

Looks good! Thanks for adding all of the tests.
I tested the UI, works as expected (aside from one potential bug I've described below). Tried both cube and normal fits.

Few comments:

• isCsysDirMatching is not called anymore. So its reference be removed from PlotViewUtil-test.js (the jest.spyOn line ~1351) and from isCsysDirMatching
• very minor: the fields nameOrType and naxis in DirectFileAccess appear to not be in use (claude helped catch this), so can be removed unless left in there for future use.
• Potential bug:
  • For regular fits (like the PanStarrs example), point and line extraction read tiles at the zoom level currently on screen, this gives different values for different zooms (for the same selected point).
    • For reference, see these 2 tables that i pinned for the same extracted point, just at different zoom levels:
    • 
    • 
    • the tile and hdu values are different for the same ra/dec.
• I say potential bug because I wasn't sure if this is intentional or not.

Other than this, looks good to me!

[robyww]

Potential bug:

This is working as intended but I understand why it is concerning. However, that is not really a good solution. The extraction works at the tiles at that level. when you zoom in you get a different set of tiles. If we relied on the lowest level of tiles then line extraction could possibly have to transfer 1500 fits files to work.

[robyww]

nameOrType and naxis in DirectFileAccess

they is there for future use