Repository navigation
FIREFLY-2076: Fix charts not showing for table/chart IDs containing a period - #2054
Merged
Merged
Conversation
stargaser
approved these changes
Oct 29, 2026
stargaser
left a comment
Contributor
There was a problem hiding this comment.
I tested it and it works great! Thank you for this fix.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FIREFLY-2076
A period in a table or chart ID (e.g.
tbl_id='2mass.catalog'from the Python client) left the table's default chart empty, andshow_chart(chartId='color.mag')drew a blank chart. Lodash string paths treat.as nesting, soupdateSet(state, chartId, …)inChartsCntlrstored the chart understate['default-2mass'].catalogwhile readers looked up the whole key;TableStatsCntlrhad the same mismatch for column stats. Imageplot_ids and region layer IDs with periods were checked and already work. No firefly_client changes are needed: IDs with periods now work as-is.See the first commit's diff for the fix (array paths, plus
CSS.escapefor the chart Save button's#${chartId}selector) and dotted-ID reducer tests.Additional refactor: The second commit (separately revertable) replaces lodash
get/set/updateSetwith?.,[]and spreads in those reducers and chart getters, keeping no-opCHART_UPDATE/CHART_TRACE_REMOVEreturning the samestate.Testing
https://firefly-2076-period-in-id-bug.irsakubedev.ipac.caltech.edu/firefly/
Using firefly_client pointed at the URL above (
fc = FireflyClient.make_client(url=..., launch_browser=False), then openfc.get_firefly_url()):fc.show_table("http://irsa.ipac.caltech.edu/TAP/sync?FORMAT=IPAC_TABLE&QUERY=SELECT+*+FROM+fp_psc+WHERE+CONTAINS(POINT('J2000',ra,dec),CIRCLE('J2000',202.4841667,47.23055556,0.125))=1", tbl_id='2mass.catalog')→ Active Chart shows the default chart (empty before this fix); table, coverage and catalog overlay as usualfc.show_chart(data=[{'tbl_id': '2mass.catalog', 'x': 'tables::j_m', 'y': 'tables::h_m-k_m', 'type': 'scatter', 'mode': 'markers'}], chartId='color.mag')→ chart renders under Pinned Chart