Repository navigation
FIREFLY-2155: Fix multi-chart views freezing the app on spectral lines plotting - #2055
Merged
Merged
Conversation
kpuriIpac
approved these changes
Oct 30, 2026
kpuriIpac
left a comment
Contributor
There was a problem hiding this comment.
Looks good. Thanks for the fix!
Testing works as decribed.
Contributor
|
confirm this works! thank you! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes FIREFLY-2155
Loading spectral lines hung the browser in multi-chart views, e.g. Euclid's data product spectra (one row → 3 spectrum charts) and Pinned Charts after using Zoom/Pan. Plotly emits
plotly_selectedon its own whenever it fully redraws a chart whoselayout.selections(the persisted box/lasso selection outline) is set, even to[], which Firefly sets after table selection syncs, Zoom/Pan and clearing a selection.PlotlyWrappertreated that event as a user selection and activated the chart; activating one chart re-rendered the others, and with spectral lines on that re-render became a full redraw, so the charts kept activating each other in a loop.A chart is now only activated on
plotly_selectedafter aplotly_selectingevent, which Plotly only emits during a user's box/lasso drag.Testing
https://firefly-2155-line-plotting-bug.irsakubedev.ipac.caltech.edu/applications/euclid/
deep_survey,2626785781669233495→ Spectra tab → Spectral lines → load SPHEREx line list → all 3 charts get lines, no hanghttps://firefly-2155-line-plotting-bug.irsakubedev.ipac.caltech.edu/firefly/