[kpuriIpac]

• Issue 1 FIREFLY-2153
  • In the Euclid app, switching to a DR1 Stacked Frames results tab froze the browser if a MER or Objects tab
    was loaded after it (and you tried switching back to the Stacked Frames tab)
  • Reason: the image viewer checked its last-used layout (grid - used by MER tables) instead of the current table's own
    layout (single - used by stacked frames), so it kept trying to switch to single, causing an endless loop & freeze.
  • Fix: now it checks the table's own layout.
• Issue 2: FIREFLY-2154
  • IFE PR has this fix: https://github.com/IPAC-SW/irsa-ife/pull/484
  • Bug: on a fresh reload (no results), if you try to load ANY search by id job (q1 or dr1, images or objects), it won't work and will just take you back to the landing page, until you load a non-id job from the job monitor; then you'll see all your jobs (including the ID jobs you tried to load)
  • Fix: Search by ID's FormWatcher now wraps FormPanel so requests carry form_submitTo; ID results loaded
    from the job monitor now open the results view instead of the landing page.
  • Another small fix: Make result tbl_ids unique across page loads (uniqueTblId) instead of a per-page counter (this solves a issue where, when let's say you load a Q1 images result from job monitor. Then you load a Q1 images (ID) result, this could overwrite the Q1 images result. this is now fixed.
• General UI fixes/changes:
  • Number 1 from confluence doc: removed Q1 tabs from showing up by default, moved them to hamburger menu
  • Number 19 from confluence doc: removed deep_visits option from DR1 object searches (this will be added back post Nov 12)
  • Number 24 from confluence doc: made the suggested text change for Euclid landing page
  • Made DR1 the default in Search by ID tab (instead of Q1) (not in confluence doc (i think), but requested via slack).

Testing:

• Euclid: https://firefly-2153-euclid-bugs.irsakubedev.ipac.caltech.edu/applications/euclid
• For Issue 1 FIREFLY-2153:
  • In DR1 images tab, do a VIS/NISP Stacked Frames search (e.g.: 4h08m24.02s -47d53m48.0s)
  • Then, from the DR1 images tab again, do a MER Mosaics search (Wide/Deep, Both or either one). Can use 4h08m24.02s -47d53m48.0s again.
  • Switch between the 2 results. It should not matter whether you load these from job monitor or wait for the results.
  • You can also retry the steps in the ticket again @lrebull, that should also work now.
• For Issue 2 FIREFLY-2154:
  • Run a Search by ID search. e.g.: Release DR1, Objects, Catalog wide_mode, ID 100000068049669902
  • Reload the page.
  • Load this job from the job monitor; you should now see your results instead of being taken to the landing page.
  • Repeat for any other ID/non-ID searches, reload the page, and load the jobs from the job monitor (try the ID searches first)

Known issue (unrelated to this PR, and only affecting dev builds): in a dev build, closing and reopening the DR1 Objects (ID) table without reloading might freeze the tab. Does not affect test or ops builds.

• (due to a BigInt error, React’s dev-only logging can’t handle very large integer IDs. We will fix this for dev builds soon, but this will not affect production builds).
• Once I put out a new Euclid version on irsacloud, you will not encounter this there.

[loitly]

I tested the changes, and everything looks good. This takes care of several last-minute bugs. Thanks for getting these fixed!

[loitly]

Please shorten the comment, but explain how changeLayout in MultiViewCntlr.js can get out of sync and cause an infinite loop. I understand that is a high-impact change and shouldn't be done at this time.

[lrebull]

• confirm Q1 stuff hidden when you load the tool
• confirm that the tool no longer runaway when you load four results from dr1 images searches
• confirm dr1 now the default in search by id (this is actually in the confluence grid, part of number 1!)
• confirm can load ID search results from job monitor
• confirm that the landing page language includes pointer to Q1 data in the side menu

🎉 woohoo!