Skip to content

Firefly-2149: Fix bug in identifying paginated image sets - #2057

Merged
aventura121 merged 1 commit into
devfrom
FIREFLY-2149-spherex-image-sets
Oct 30, 2026
Merged

aventura121 merged 1 commit into
devfrom
FIREFLY-2149-spherex-image-sets

Conversation

@aventura121

@aventura121 aventura121 commented Oct 30, 2026 •

Copy link
Copy Markdown
Contributor

Firefly-2149 SPHEREx image sets are unexpected

Description: The table colored a clicked row's image-set partners by looking up rows with page positions (0–99) instead of whole-table positions (e.g. 0-499), so pages after the first page compared against page 1's rows. The fix adds the page's starting row to both positions.

Builds:

SPHEREx build: https://firefly-2149-spherex-image-sets.irsakubedev.ipac.caltech.edu/applications/spherex/

Firefly build: https://firefly-2149-spherex-image-sets.irsakubedev.ipac.caltech.edu/firefly

Validation:

In the SPHEREx app:

  1. Open the SPHEREx Spectral Image Search on the branch build. Enter m51 in Coordinates or Object Name, keep all the defaults, and click Search. The results table shows 418 rows on 5 pages.

(Bug 2 from Jira: wrong rows marked as an image set on page 4)

  1. Click Next Page (›) three times to reach page 4. Its first row, 2025W51_2A_0177_1 (spherex_dr1), is highlighted.
    • No other row is lighter yellow. (Note: this image's real partner is the last row of page 3, which is not shown in the page).
  2. Click the second 2026W20_2A_0183_1 row, which is the third row on the page.
    • The 2026W20_2A_0183_1 row above it turns lighter yellow.

(Bug 1 from Jira: image set disappears after clearing a filter)

  1. Type 2 in the page number box and press Enter. Scroll down about 20 rows and click the first 2025W21_1B_0508_1 row.
    • The other 2025W21_1B_0508_1 row is lighter yellow.
  2. Type 2025w21 in the filter box under obs_id and press Enter.
    • The pair is still marked.
  3. Click Remove all filters (the funnel with an ✕) in the table toolbar. The table goes back to page 2 with the same row highlighted.
    • The other 2025W21_1B_0508_1 row is still lighter yellow.

@aventura121 aventura121 added this to the 2026.4 milestone Oct 30, 2026
@aventura121 aventura121 self-assigned this Oct 30, 2026
@aventura121
aventura121 marked this pull request as ready for review October 30, 2026 19:02
@lrebull

lrebull commented Oct 30, 2026

Copy link
Copy Markdown
Contributor

confirm this is fixed!

@kpuriIpac kpuriIpac left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, tested work as described.

Thanks for adding the test!

@aventura121
aventura121 force-pushed the FIREFLY-2149-spherex-image-sets branch from 6d016c3 to fc88e6f Compare October 30, 2026 23:02
@aventura121
aventura121 merged commit e0bee20 into dev Oct 30, 2026
2 checks passed
@aventura121
aventura121 deleted the FIREFLY-2149-spherex-image-sets branch October 30, 2026 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants