Repository navigation
Firefly-2149: Fix bug in identifying paginated image sets - #2057
Merged
Merged
Conversation
Contributor
|
confirm this is fixed! |
kpuriIpac
approved these changes
Oct 30, 2026
kpuriIpac
left a comment
Contributor
There was a problem hiding this comment.
Looks good, tested work as described.
Thanks for adding the test!
aventura121
force-pushed
the
FIREFLY-2149-spherex-image-sets
branch
from
October 30, 2026 23:02
6d016c3 to
fc88e6f
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Firefly-2149 SPHEREx image sets are unexpected
Description: The table colored a clicked row's image-set partners by looking up rows with page positions (0–99) instead of whole-table positions (e.g. 0-499), so pages after the first page compared against page 1's rows. The fix adds the page's starting row to both positions.
Builds:
SPHEREx build: https://firefly-2149-spherex-image-sets.irsakubedev.ipac.caltech.edu/applications/spherex/
Firefly build: https://firefly-2149-spherex-image-sets.irsakubedev.ipac.caltech.edu/firefly
Validation:
In the SPHEREx app:
m51in Coordinates or Object Name, keep all the defaults, and click Search. The results table shows 418 rows on 5 pages.(Bug 2 from Jira: wrong rows marked as an image set on page 4)
2025W51_2A_0177_1(spherex_dr1), is highlighted.2026W20_2A_0183_1row, which is the third row on the page.2026W20_2A_0183_1row above it turns lighter yellow.(Bug 1 from Jira: image set disappears after clearing a filter)
2in the page number box and press Enter. Scroll down about 20 rows and click the first2025W21_1B_0508_1row.2025W21_1B_0508_1row is lighter yellow.2025w21in the filter box under obs_id and press Enter.2025W21_1B_0508_1row is still lighter yellow.