Skip to content

#138 soupsieve 4.1.1 past co-core's cap, opentelemetry-api 1.45.2; LOCAL_GENERATION 4 - #139

Merged
gregoryfoster merged 7 commits into
mainfrom
138-lock-advisories
Nov 16, 2026
Merged

gregoryfoster merged 7 commits into
mainfrom
138-lock-advisories

Conversation

@gregoryfoster

@gregoryfoster gregoryfoster commented Nov 16, 2026 •

Copy link
Copy Markdown
Member

Refs #138 (epic #84, Tier 1). Live checks remain after the merge, so this doesn't close the issue.

What

  • soupsieve 2.10 → 4.1.1, by [tool.uv] override-dependencies = ["soupsieve>=4.1,<5"]. It fixes GHSA-mmhr-3c5m-f64f, GHSA-6655-6qjp-jx7x and GHSA-7g44-g9rc-x53w.
  • opentelemetry-api 1.45.1 → 1.45.2, by its constraint-dependencies floor (GHSA-mf5v-w3w3-f6cg). Not extraction stack.
  • LOCAL_GENERATION 3 → 4: processor_version becomes 0.38.0+4. soupsieve is extraction stack (spec §5).
  • tests/test_lock_floors.py:
    • both floors, in the lock and the venv;
    • the override, declared;
    • a guard on co-core's own Requires-Dist: once co-core's requirement admits soupsieve ≥ 4.1 (its floor reaches it, or its cap lifts), the guard fails and names the override to remove.
  • tests/test_pin.py: EXTRACTION_STACK soupsieve 4.1.1, GENERATION 4.
  • Docs:
    • the spec: an Amended entry, plus §5 and §7;
    • DEPENDENCIES.md: the override route (§ Extraction dependencies, § The lock audit, § CI pins), its removal at the bump (§ Bumping co-core), and the Since line;
    • the plan.

Lock diff

bash scripts/co-pypi.sh uv lock --upgrade-package soupsieve --upgrade-package opentelemetry-api resolved 64 packages and moved those two alone. The manifest records overrides = [{ name = "soupsieve", specifier = ">=4.1,<5" }]. All three co-core sources are still the co-pypi index URL.

Evidence

  • Parity: the goldens and the real corpus pass unchanged (tests/processors/test_extract.py, tests/test_gen_parity_goldens.py).
  • Containment: child containment: required (Landlock ABI 6). test_the_whole_parity_corpus_is_identical_through_the_child passes. tests/test_child.py: 40 passed, 7 skipped (environmental: credential files this user can't read, no docker socket).
  • The full suite: 995 passed, 15 skipped locally (not integration). CI on 82f35a8: 1026 passed, containment required (Landlock ABI 8). The PR's audit reads 0.
  • Wider corpus (DEPENDENCIES.md § Extraction dependencies, step 3):
    • Inputs and runs: co-core 0.38.0's HtmlExtractor, then canonical_text_fingerprint. 289 HTML files (the parity HTML, the real corpus, every HTML file over 3 KB on co-processor) × 34 selector configs, so 9,826 runs per version. The two venvs differ in soupsieve alone (2.10 / 4.1.1), with 30 s per run.
    • Result: 0 fingerprints moved. 867 runs differ, and every one is a refusal:
      • div:has(p a) and div:has(div:has(p)): 289 files each go from a result to UnsupportedExtractionError. soupsieve 3.0's strict :has() refuses a complex or nested :has(); div:has(> p) still compiles;
      • "a >": refused on both versions, with the reason reworded (Invalid character ' ' position 1).
    • Timeouts: 4 on 2.10, 2 on 4.1.1, all on one 10 MB page; 4.1.1's two also time out on 2.10. Total time: 1,154 s on 2.10, 1,012 s on 4.1.1.
    • <template> (4.0's break): selectors no longer descend into one, but HtmlExtractor takes no text from a template on either version. Probed: identical.

Review

The reviewing-code pass found 4 findings, fixed as CR 1–CR 4:

  • the guard keys on co-core's range admitting the floor, a lifted cap included;
  • the pyproject comment;
  • exact name and extra matching;
  • the spec entry's wording.

A fifth (no separate red commit) is declined: main holds every commit green.

After the merge (on #138)

  • The Watcher notice on watcher#394, with approval.
  • scripts/deploy.sh, which also restarts processor onto the 11-13 glibc.
  • The live release venv shows soupsieve 4.1.1 and opentelemetry-api 1.45.2, and the logs show processor_version 0.38.0+4.
  • The audit on main reads 0, and Dependabot alerts 12–15 close.
  • PR chore: bump opentelemetry-api from 1.45.1 to 1.45.2 #135 closes in favour of this one.

🤖 Generated with Claude Code

gregoryfoster and others added 7 commits November 16, 2026 18:05
….2, LOCAL_GENERATION 4

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…2; LOCAL_GENERATION 4

soupsieve 2.10 has three selector DoS advisories (GHSA-mmhr-3c5m-f64f,
GHSA-6655-6qjp-jx7x, GHSA-7g44-g9rc-x53w); co-core 0.38.0's extract extra caps
it <3, so [tool.uv] override-dependencies = soupsieve>=4.1,<5 replaces that
requirement until the co-core bump to >=0.46.1. opentelemetry-api's floor moves
to 1.45.2 (GHSA-mf5v-w3w3-f6cg). The lock moves those two alone; the co-core
sources stay the co-pypi index.

soupsieve is extraction stack, so LOCAL_GENERATION 3 -> 4 (processor_version
0.38.0+4). test_lock_floors.py holds both floors, the override, and a guard
that fails once co-core's own requirement makes the override redundant.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…route

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…or, not only floors at it

A co-core release that lifts soupsieve's cap without raising its floor
(>=2.0,<5) makes the override redundant too: a constraint floor would do.
The guard now reads co-core's upper bounds (< and <=, padded), with controls.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
The override entry matched by prefix, and co-core's marker by substring
('extraction' would count). One _names helper for both requirement reads,
the marker matched as extra == 'extract', with controls.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
…hem a new refusal

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant