[MostCromulent]

Summary

Fixes two crashes from #12521 (format dropdown) and #12522 (Canadian Highlander). The desktop one was reported. The mobile one was found by a code audit of both PRs and has not been reported.

Bug report

Desktop (reported): opening a booster draft throws.

java.lang.NullPointerException: Cannot invoke "...DeckController.getModel()" because the return value of "...ACEditorBase.getDeckController()" is null
    at forge.screens.deckeditor.controllers.CStatistics.analyze(CStatistics.java:125)
    at forge.screens.home.sanctioned.CSubmenuDraft.setupDraft(CSubmenuDraft.java:233)

Mobile (from code analysis): switching the lobby's Variants list from one variant to another can throw a ClassCastException.

Root cause

• Add Canadian Highlander format #12522's points line in `CStatistics` reads `getDeckController().getModel()`. The draft, quest draft, Winston, network draft, quest shop and token viewer editors have no deck controller, so a pick or card move in any of them can throw.
• Unify Constructed format selection in the lobby and deck editor #12521's Variants handler clears the old variant through `removeVariant`, which refreshes the lobby and resets the list to "(None)". The handler then casts "(None)" to `GameType`.

Fix

• CStatistics hides the points line when the editor has no deck controller.
• The Variants handler reads the chosen variant before clearing the old one.

Audit

Every file in both PRs was checked for other runtime errors, on desktop, mobile and Android (minSdk 26: d8 backports the new List.of, Map.copyOf and record uses). No other crash was found.

---

🤖 Generated with Claude Code