Skip to content

Fix multiplayer save button positioning with DirectDraw wrappers - #105

Merged
Belonit merged 1 commit into
mainfrom
fix/multiplayer-save-button-positioning
Nov 14, 2026
Merged

Belonit merged 1 commit into
mainfrom
fix/multiplayer-save-button-positioning

Conversation

@Belonit

@Belonit Belonit commented Nov 8, 2026

Copy link
Copy Markdown
Member

Closes #103

@github-actions

github-actions Bot commented Nov 8, 2026

Copy link
Copy Markdown

Nightly build for this pull request:

This comment is automatic and is meant to allow guests to get latest nightly builds for this pull request without registering. It is updated on every successful build.

@Belonit Belonit added bug Something isn't working Needs testing labels Nov 8, 2026
@GreyVacuum

Copy link
Copy Markdown
Contributor

The issue of the resolution Y-coordinate button alignment being inaccurate has been confirmed and checked, and this PR is fine.

This issue occurs in windowed mode of cnc-ddraw, while other ddraw versions (such as ts-ddraw) run normally.
Tests conducted at 800x600 resolution

  • Before fix

windowed
image
Full screen
image

  • After fix

windowed
image
Full screen
image

@Belonit
Belonit merged commit 3d6adb3 into main Nov 14, 2026
3 checks passed
@Belonit
Belonit deleted the fix/multiplayer-save-button-positioning branch November 14, 2026 17:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

bug Something isn't working Tested

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Is there a potential issue with dynamically adding the multiplayer game save button?

2 participants