Skip to content

docs(router): link workspace billing to /settings/billing and localize the Add credits quickstart step - #2442

Merged
mattmillerai merged 1 commit into
mainfrom
mattmiller/be-27238-router-billing-links
Nov 20, 2026
Merged

mattmillerai merged 1 commit into
mainfrom
mattmiller/be-27238-router-billing-links

Conversation

@mattmillerai

Copy link
Copy Markdown
Member

ELI5

The Comfy Router docs sent people who wanted to check their bill or buy credits to the platform home page, so they had to hunt for billing themselves. Now those links go straight to the billing page in every language, and the Spanish, Japanese, Korean and Chinese quickstarts gain the same optional "add credits first" step that the English quickstart is getting.

What

  • development/comfy-router/billing.mdx (English, not sync-owned) and its es/ja/ko/zh copies: "workspace usage and invoices" now links to https://platform.comfy.org/settings/billing.
  • es/ja/ko/zh limitations.mdx and litellm.mdx: the "workspace billing" link now points at /settings/billing.
  • es/ja/ko/zh quickstart.mdx, mirroring the upstream English change (merged upstream, not yet carried here by the sync):
    • New optional first step, "Add credits to your workspace (optional)", translated, linking to /settings/billing and to the locale's Router billing page.
    • The credits paragraph in the API-key step is trimmed to the upstream pointer. It keeps the note that the 402 credit check runs before body validation.
    • Other step titles and content are unchanged.
  • English quickstart.mdx, limitations.mdx and litellm.mdx are not touched. They are sync-owned and get the same change from the upstream source on the next sync.
  • The open i18n bot PR i18n: sync zh/ja/ko and es translations with upstream/main (2026-11-20) #2427 touches locale limitations.mdx but does not change these links, so nothing here duplicates it. If it conflicts, it will be on that single table row.

Testing

  • check-i18n-sync.mjs against the merge base: all checks passed. The English billing.mdx change has matching es/ja/ko/zh changes.
  • check-sync-owned.ts on the changed file list: no sync-owned files edited (17 checked).
  • mint broken-links: no broken links found.
  • git grep -n '](https://platform.comfy.org)' -- '*comfy-router*': no locale hits left. The only remaining hits are the 4 sync-owned English lines (see Residual).
  • Doc-drift sweep: 5 references checked, 0 updated. The insufficient_credits and Idempotency-Key mentions in openapi-v2.yaml and a README line are still accurate.

Provenance

  • Authored by: agent-work loop
  • Verified:
    • i18n sync check: passed
    • Sync-owned check: passed (no guarded files edited)
    • Mintlify broken-links: none found
    • Bare-platform-link grep: zero locale hits
    • Not run: Mintlify preview render, signed-in browser check of the billing URL
  • Deviations:
    • The acceptance grep is not empty yet. The 4 remaining hits are in sync-owned English files that this PR must not edit, and the upstream sync fixes them.
    • The English Add-credits step had not been synced into this repo yet, so the translations follow the merged upstream English source.

Residual

  • English sync-owned pages still link to the bare platform URL (development/comfy-router/{quickstart,limitations,litellm}.mdx, plus the quickstart has no Add-credits step yet). The upstream change is merged but no "sync Comfy API v2 specification and Comfy Router pages" PR has carried it yet. Until it does, git grep -n '](https://platform.comfy.org)' -- '*comfy-router*' returns those 4 English lines, and the English quickstart has one step fewer than the locales. When the sync lands, re-run the grep and confirm it is empty.
  • Mintlify preview not checked. The PR preview still needs a look to confirm the quickstart steps render in order in en/es/ja/ko/zh. mint broken-links parsed every page without error, but that does not check rendering.
  • Billing link not opened signed in. Nobody has yet opened https://platform.comfy.org/settings/billing in a signed-in browser to confirm it reaches the billing page. The path comes from the platform app's settings routes, and the upstream English change uses the same URL.
  • Translation review. The new step text was translated by hand to match the terms already used on each locale's Router pages. A native-speaker pass or pnpm translate:review would catch tone issues.
  • An upstream draft also edits the English Router quickstart, in a different region (migration card). It does not affect this repo's locale files until it syncs.

🤖 Generated with Claude Code

… localized Add credits quickstart step

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@mattmillerai mattmillerai added cursor-review Trigger Cursor automated review agent-coded PR authored by the agent-work loop labels Nov 20, 2026
@mintlify

mintlify Bot commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Preview deployment for your docs. Learn more about Mintlify Previews.

Project Status Preview Updated
comfy 🟢 Ready View Preview Nov 20, 2026, 11:41 PM

💡 Tip: Enable Automations to automatically generate PRs for you.

@coderabbitai

coderabbitai Bot commented Nov 20, 2026 •

Copy link
Copy Markdown

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Router documentation updates billing links to workspace billing settings in English and four translations. The translated quickstarts add an optional credit step and describe the 402 insufficient_credits response, including that credit checks occur before request-body validation.

Changes: Router billing documentation

Layer / File(s) Summary
Translated quickstart credit guidance
es/development/comfy-router/quickstart.mdx, ja/development/comfy-router/quickstart.mdx, ko/development/comfy-router/quickstart.mdx, zh/development/comfy-router/quickstart.mdx
The quickstarts add an optional step to add workspace credits and describe the 402 insufficient_credits response. They state that credit checks occur before request-body validation.
Workspace billing links
development/comfy-router/billing.mdx, es/development/comfy-router/{billing,limitations,litellm}.mdx, ja/development/comfy-router/{billing,limitations,litellm}.mdx, ko/development/comfy-router/{billing,limitations,litellm}.mdx, zh/development/comfy-router/{billing,limitations,litellm}.mdx
Billing links point to workspace billing settings instead of the platform home page.

Suggested reviewers: lin-bot23, stale2000, robinjhuang

Merge Risk: Minimal · up to 83a96

This documentation update points billing links at the workspace billing settings page and adds an optional credits step to the translated quickstarts. No concrete defect was found, and the change is low risk to merge. The new translations have not had a native-speaker review.

Pre-merge checks: Passed 2

Check name Status Explanation
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
Simplify code

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Warning

Some tools did not complete. Review the errors below.

LanguageTool

LanguageTool checks are incomplete because the shared provider circuit is open. Remaining chunks and files were skipped; findings from completed checks are retained.

ja/development/comfy-router/billing.mdx

LanguageTool could not check every text chunk; analysis is incomplete

ja/development/comfy-router/limitations.mdx

LanguageTool could not check every text chunk; analysis is incomplete

ko/development/comfy-router/limitations.mdx

LanguageTool could not check every text chunk; analysis is incomplete

  • 2 others

CI annotation context is incomplete: annotation collection unavailable or limited

Recent review info

Run configuration

  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: Organization UI
  • Review profile: ASSERTIVE
  • Plan: Team
  • Run ID: d2ec00a6-48d2-4db5-a56e-b6d9035241fb
Commits

Reviewing files that changed from the base of the PR and between 307b295 and 83a9623.

Files selected for processing: 17

  • development/comfy-router/billing.mdx
  • es/development/comfy-router/billing.mdx
  • es/development/comfy-router/limitations.mdx
  • es/development/comfy-router/litellm.mdx
  • es/development/comfy-router/quickstart.mdx
  • ja/development/comfy-router/billing.mdx
  • ja/development/comfy-router/limitations.mdx
  • ja/development/comfy-router/litellm.mdx
  • ja/development/comfy-router/quickstart.mdx
  • ko/development/comfy-router/billing.mdx
  • ko/development/comfy-router/limitations.mdx
  • ko/development/comfy-router/litellm.mdx
  • ko/development/comfy-router/quickstart.mdx
  • zh/development/comfy-router/billing.mdx
  • zh/development/comfy-router/limitations.mdx
  • zh/development/comfy-router/litellm.mdx
  • zh/development/comfy-router/quickstart.mdx

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 0 remain after this review.

@mattmillerai
mattmillerai merged commit b7bfeb0 into main Nov 20, 2026
15 checks passed
@github-actions
github-actions Bot deleted the mattmiller/be-27238-router-billing-links branch November 20, 2026 23:43

This branch was successfully deployed

1 active deployment
staging — 83a96231 Deployed Nov 20, 2026 by mintlify[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

agent-coded PR authored by the agent-work loop cursor-review Trigger Cursor automated review

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant