Repository navigation
Conversation
luqq-md
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR addresses the issue where
concore validateaccepts node source paths that point outside the configured source directory.As mentioned in the issue, a workflow referencing
../outside.pywas reported as valid when the file existed outside the source directory. However, runningconcore buildon the same workflow resulted in an unsafe path error.I've fixed this by adding source path validation to the CLI validator, following the safety checks already used by the generator.
Now, invalid paths are caught during validation itself instead of allowing the workflow to pass validation and fail later during the build.
I've also added a regression test covering this scenario.
Test results:
git diff --check: passed.Closes #659