Skip to content

Fix duplicate rendering of Y courses in the timetable grid - #1836

Open
Purplegaze wants to merge 11 commits into
Courseography:masterfrom
Purplegaze:y-duplication-fix
Open

Purplegaze wants to merge 11 commits into
Courseography:masterfrom
Purplegaze:y-duplication-fix

Conversation

@Purplegaze

@Purplegaze Purplegaze commented Nov 20, 2026 •

Copy link
Copy Markdown
Contributor

Proposed Changes

Depends on #1831

Updates grid rendering to sort lecture timeframes by timeSession instead of session. This fixes an issue where Y courses were appearing duplicated on the timetable.

Screenshots

Before

image

After

image

Type of Change

(Write an X or a brief description next to the type or types that best describe your changes.)

Type Applies?
🚨 Breaking change (fix or feature that would cause existing functionality to change)
✨ New feature (non-breaking change that adds functionality)
🐛 Bug fix (non-breaking change that fixes an issue) X
🎨 User interface change (change to user interface; provide screenshots)
♻️ Refactoring (internal change to codebase, without changing functionality)
🚦 Test update (change that only adds or modifies tests)
📦 Dependency update (change that updates a dependency)
🔧 Internal (change that only affects developers or continuous integration)

Checklist

(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the [ ] into a [x] in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)

Before opening your pull request:

  • I have performed a self-review of my changes.
    • Check that all changed files included in this pull request are intentional changes.
    • Check that all changes are relevant to the purpose of this pull request, as described above.
  • I have added tests for my changes, if applicable.
    • This is required for all bug fixes and new features.
  • I have updated the project documentation, if applicable.
    • This is required for new features.
  • If this is my first contribution, I have added myself to the list of contributors.
  • I have updated the project Changelog (this is required for all changes).

After opening your pull request:

  • I have verified that the CI checks have passed.
  • I have reviewed the test coverage changes reported by Coveralls.
  • I have requested a review from a project maintainer.

Questions and Comments

(Include any questions or comments you have regarding your changes.)

@coveralls

coveralls commented Nov 20, 2026 •

Copy link
Copy Markdown

Coverage Report for CI Build 44949731344

Coverage increased (+0.07%) to 61.721%

Details

  • Coverage increased (+0.07%) from the base build.
  • Patch coverage: 4 uncovered changes across 2 files (0 of 4 lines covered, 0.0%).
  • No coverage regressions found.

Uncovered Changes

File Changed Covered %
js/components/grid/Row.tsx 2 0 0.0%
js/components/grid/calendar.ts 2 0 0.0%

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 4299
Covered Lines: 2701
Line Coverage: 62.83%
Relevant Branches: 999
Covered Branches: 569
Branch Coverage: 56.96%
Branches in Coverage %: Yes
Coverage Strength: 157.89 hits per line

💛 - Coveralls

courseCode: lectureSection.courseCode,
session: lectureSection.session,
timeSession: time.timeSession,
timeSession: time.timeSession!,

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In general ! should be avoided. We made this field optional in the backend, but to keep the type stricter here we could use time.timeSession || "", causing the session data to be ignored. (I'm not sure if this is the best approach, or whether the check you modified should check session as a fallback if timeSession isn't specified.)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants