Repository navigation
Fix duplicate rendering of Y courses in the timetable grid - #1836
Open
Purplegaze wants to merge 11 commits into
Open
Purplegaze wants to merge 11 commits into
Purplegaze wants to merge 11 commits into
Conversation
… into typescript-calendar
… into typescript-calendar
Coverage Report for CI Build 44949731344Coverage increased (+0.07%) to 61.721%Details
Uncovered Changes
Coverage RegressionsNo coverage regressions found. Coverage Stats
💛 - Coveralls |
| courseCode: lectureSection.courseCode, | ||
| session: lectureSection.session, | ||
| timeSession: time.timeSession, | ||
| timeSession: time.timeSession!, |
Contributor
There was a problem hiding this comment.
In general ! should be avoided. We made this field optional in the backend, but to keep the type stricter here we could use time.timeSession || "", causing the session data to be ignored. (I'm not sure if this is the best approach, or whether the check you modified should check session as a fallback if timeSession isn't specified.)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Proposed Changes
Depends on #1831
Updates grid rendering to sort lecture timeframes by
timeSessioninstead ofsession. This fixes an issue where Y courses were appearing duplicated on the timetable.Screenshots
Before
After
Type of Change
(Write an
Xor a brief description next to the type or types that best describe your changes.)Checklist
(Complete each of the following items for your pull request. Indicate that you have completed an item by changing the
[ ]into a[x]in the raw text, or by clicking on the checkbox in the rendered description on GitHub.)Before opening your pull request:
After opening your pull request:
Questions and Comments
(Include any questions or comments you have regarding your changes.)