Repository navigation
fix(Select, Snackbar, Avatar): screen reader fixes - #1180
Open
shubham-kumar1-eightfold wants to merge 5 commits into
Open
shubham-kumar1-eightfold wants to merge 5 commits into
shubham-kumar1-eightfold wants to merge 5 commits into
Conversation
…ader and zoom fixes
…ernal popup selector; revert the FocusTrap change
…the dialog Escape, reflow and overlay changes
schakka-eightfold
approved these changes
Oct 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
SUMMARY:
Screen reader fixes. Only the Snackbar change affects existing usages; the other two are opt-in.
improvedA11y, the results live region clears when the list closes, so a stale "N matches found." is no longer read in browse mode, and the count is announced again on reopen. WithoutimprovedA11ynothing changes.SnackbarContainers mounted, each snack renders once instead of once per container. The serve event is now cancelable, and the first container to receive it claims it.ariaHiddenprop, named as onIconandTextInput, to hide a decorative avatar (for example one next to the person's name).aria-hiddenpassed toAvatarwas silently dropped.GITHUB ISSUE (Open Source Contributors)
NA
JIRA TASK (Eightfold Employees Only):
https://eightfoldai.atlassian.net/browse/ENG-222073
https://eightfoldai.atlassian.net/browse/ENG-222080
https://eightfoldai.atlassian.net/browse/ENG-222081
CHANGE TYPE:
TEST COVERAGE:
TEST PLAN:
improvedA11ylist closes; Snackbar renders once with two containers; AvatarariaHidden.yarn test: 231 suites pass.improvedA11ySelect, an Avatar and a snack: live region empty after the list closes; one snack; avatar hidden from the accessibility tree.SnackbarContainers a toast renders once; theimprovedA11ySelect's live region empties after the list closes; anariaHiddenavatar is ignored by the accessibility tree.