Repository navigation
Fix knowledge export authorization and durable artifact selection - #53
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
An owned knowledge registration previously allowed a shared external tree to enter an experiment package, and artifact selection both dropped durable Script output directories and retained actual workspace scratch. Require an explicit operator grant for an exact external bundle root, check foreign/ownerless registration and grant overlaps before any content capture, and recognize workspace scratch by its structural location.
Application-owned upload/document roots retain their existing per-owner boundary. Isolated legacy external bundles remain supported through
ASAREE_KNOWLEDGE_EXPORT_GRANTS; the grant is an operator assertion that all content under that exact root is authorized for the user, not a filesystem-ownership inference. Broad roots, overlap or missing/ambiguous evidence produce generic unresolved dependencies without foreign paths, identifiers, commands or bytes. The schema and existing package format are unchanged.Preserve arbitrary user
outputs/working,cache,scratch,__pycache__,.scratch, andresults.preparingdirectories. Exclude actual root/dataset=/agent= workspace.scratchand reserved hidden preparation names. Document grant semantics and API/results-worker configuration.Validation:
_serverarchives, iterate supplied foreign registration rows, prove denied capture never starts, cover exact grants/legacy positives and ownerless/missing evidence, and execute a real wired Script plus Workspace.open/_scratch_dir fixtures.References EpistasisLab/ASAREE_Issues#55.
Integration verification: PR CI 42754206793 and post-merge CI 42755013514 passed; 2,061 backend tests, 3 skipped. Frontend/statistical suites skipped by scope. Existing warn-only mypy backlog remains 693 errors in 57 files.