Repository navigation
Import portable experiment packages with owned dependencies and historical evidence - #54
Merged
Merged
Conversation
added 8 commits
November 9, 2026 20:18
… feat/70-import-experiment-packages
Validate canonical MCP identities and requirement/directory agreement, and check resolved payload containment before reading or copying resources. Restore nested SKILL.md resources instead of treating them as root entrypoints. Discard never-validated payloads without parsing dependency inventories and isolate cleanup transactions and enqueue failures per request. Add schema 1/2 archive regressions, PostgreSQL nested resource round trips, and mixed-request cleanup rollback/retry coverage. Verified full local backend and frontend CI suites before pushing.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implements EpistasisLab/ASAREE_Issues#70.
ASAREE could export published experiment packages but could not restore them. This adds owned upload, validation/preflight, explicit confirmation and staged activation in the API and UI. Each import creates a fresh editable experiment and owned dependencies. Source publications, sampling evidence, optional historical attempts and artifacts remain immutable evidence, separate from local execution. Local credentials and connections must be configured and acknowledged before normal publication and execution.
Imports preserve exact dataset/split files, design cells and planned replicates, factor alternatives, complete Skills, knowledge bundles/documents and typed measurement references. Typed identities are remapped durably; opaque experimental values retain their content. The workflow uses the existing ASAREE/Motoro PostgreSQL databases and managed filesystem storage, with cancellation, retry, expiry, compensation and interrupted-activation recovery. Packaged scripts/tools are never executed.
The package documentation contains the component coverage matrix, API, lifecycle, limits and compatibility policy. AGENTS.md and CONTRIBUTING.md require local CI checks before pushing.
Independent review fixes since reviewed head
adf2e2a4dc6725e9497389e3fd79930b2560b3d9:Compatibility: exports remain schema 2; imports accept schemas 1 and 2, with no new migration. Both require canonical typed identities and consistent archive paths. Missing/unresolved legacy name-only dependencies remain diagnostics. V1 facts omitted by the original exporter remain unknown; they are not guessed.
Local validation, completed before pushing (native disposable PostgreSQL 16.2 + pgvector; bounded database waits and test-command timeouts):
Final head:
803fb2b9ecf5eca2a99609b4dbe0cbeb554f97bb. Required GitHub checks: all passed on this exact head (run 42890649235): backend lint/tests, frontend types/lint/tests and change selection.Remaining limits: historical evidence stays separate from current native execution projections; native Motoro step/resume history was not exported and cannot be restored. Configurable document/resource limits still apply (16 MiB by default). UI appearance has not been checked in a browser. No production databases, application credential files, paid provider calls, packaged script execution, merge or deployment were used.
Merged into
developwith merge commit31d36312ad2aeb7ccadb7decd841a8c0bc2b9417. Post-merge CI 42893074483 passed: 2,116 backend tests (3 skipped, 14 statistical cases deselected) and 652 frontend tests. Full CI mypy remains warn-only: 695 errors in 58 files under Python 3.12. The merge tree matches reviewed head803fb2b. Ancestry is preserved. No production deployment or migration was performed.