Skip to content

Make the debug implementation of Commitment print a TaggedBase64 - #54

Merged
ss-es merged 3 commits into
mainfrom
ss/make-debug-match-display
Mar 3, 2026
Merged

ss-es merged 3 commits into
mainfrom
ss/make-debug-match-display

Conversation

@ss-es

@ss-es ss-es commented Feb 27, 2026 •

Copy link
Copy Markdown
Contributor

This PR makes the Debug implementation of Commitment print:

DUMMY_TAG~AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAn

instead of

Commitment([0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0, 0], PhantomData<fn(&committable::test::DummyCommittable)>)

This also makes it match the Display instance

@gemini-code-assist

Copy link
Copy Markdown

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request refines the debugging representation of Commitment objects. By replacing the default Debug derive with a custom implementation, Commitment instances will now print as a TaggedBase64 string when debug-formatted. This change enhances the developer experience by providing a more concise and meaningful output for Commitment types in debug contexts, aligning their debug representation with their serialized form.

Highlights

  • Debug Implementation: The automatic Debug derive for the Commitment struct has been removed.
  • Custom Debug Formatting: A custom Debug implementation has been added for Commitment that formats its output as a TaggedBase64 string, improving readability during debugging.

🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Changelog
  • src/lib.rs
    • Removed the Debug derive macro from the Commitment struct.
    • Implemented the Debug trait for Commitment to output a TaggedBase64 representation, conditional on the ark-serialize feature.
Activity
  • No human activity has been recorded on this pull request yet.
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the Debug implementation for Commitment to provide a more readable TaggedBase64 representation. While this is a good improvement for usability, the current implementation makes the Debug trait conditional on the ark-serialize feature. This is a breaking change for users who disable default features, as it will cause compilation errors. My review includes a suggestion to provide a fallback Debug implementation to ensure the code compiles correctly in all feature configurations.

Comment thread src/lib.rs Resolved
Comment thread src/lib.rs Resolved
Co-authored-by: Toralf Wittner <tw@dtex.org>
@ss-es
ss-es merged commit 57c7f29 into main Mar 3, 2026
8 checks passed
@ss-es
ss-es deleted the ss/make-debug-match-display branch March 3, 2026 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants