Repository navigation
[uplift] fix: VictoryLabel default font and unused lodash deps - #3115
Merged
ryan-roemer merged 1 commit intoOct 28, 2026
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
🦋 Changeset detectedLatest commit: 52a9d9d The changes in this PR will be included in the next version bump. This PR includes changesets to release 29 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
🟢 Approval recommended
The review found no active issues in the dependency cleanup, font correction, synchronized snapshots and lockfile, or accompanying changeset.
No open issues 🎉
1 file not reviewed
pnpm-lock.yaml: Generated file
What changed in this PR
This pull request removes unused lodash dependencies and corrects the VictoryLabel default Seravek font name by removing an invisible soft hyphen. It also updates the related snapshot, lockfile, and patch changeset.
Changes:
- Removes unused
lodashdependencies from three packages. - Synchronizes
pnpm-lock.yaml. - Corrects the
VictoryLabeldefault font family. - Updates the inline snapshot and adds a patch changeset.
| File | Description |
|---|---|
pnpm-lock.yaml |
Removes the unused dependency entries. |
packages/victory-scatter/package.json |
Removes the unused lodash dependency. |
packages/victory-histogram/package.json |
Removes the unused lodash dependency. |
packages/victory-core/src/victory-label/victory-label.tsx |
Corrects the default Seravek font-family value. |
packages/victory-core/src/victory-label/victory-label.test.tsx |
Updates the expected inline snapshot. |
packages/victory-canvas/package.json |
Removes the unused lodash dependency. |
.changeset/label-font-and-unused-lodash.md |
Records patch releases for the affected packages. |
Review effort: Lite
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #3093 (Phase 2: remove cruft).
VictoryLabel's defaultfontFamilyhad an invisible soft hyphen (U+00AD) inside'Seravek'(since 2018), so that font never matched. Removed it (and from the test's inline snapshot).lodashfromdependenciesinvictory-canvas,victory-histogramandvictory-scatter(no imports; found by knip).Patch changeset. Verified:
pnpm check,pnpm pack:check(each package loads with only its declared deps).