Skip to content

[uplift] fix: docs example warnings and website cleanups - #3124

Merged
ryan-roemer merged 2 commits into
chore/2026-uplift-02from
fix/uplift-docs-examples-12
Oct 29, 2026
Merged

ryan-roemer merged 2 commits into
chore/2026-uplift-02from
fix/uplift-docs-examples-12

Conversation

@ryan-roemer

@ryan-roemer ryan-roemer commented Oct 29, 2026 •

Copy link
Copy Markdown
Member
  • Add missing keys (error-bar, bar-horizontal-stacked)
  • Skip-weekends examples (line, area, common theme props): explicit VictoryAxis with the data dates as tickValues and a short date tickFormat. Default ticks can land on a weekend and d3fc warns; its own scale.ticks() emits the same warning, so it can't supply them. Still two axes; tick labels now read "Jun 1" … "Jun 11"
  • Theme builder: Select renders value ?? "". activeChartType starts as null, which the value = "" default didn't catch (React warning)
  • Remove unused victory-typedoc plugin (never registered) and its deps (typedoc, mdast-util-from-markdown, find-cache-dir)
  • Declare lodash (+ @types/lodash) in the website
  • Type-check website src: script renamed typecheck → types:check so turbo/pnpm check/CI run it (victory-docs#types:check skips the docs build). Type-only fixes: Docusaurus types, *.png declaration, victory-core → victory import, drop utility-types, enum casts in chart-panel, dateX cast in landing-demo (DataGetterPropType lacks Date)

@changeset-bot

changeset-bot Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 3bd01d1

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vercel

vercel Bot commented Oct 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated
victory Ready Ready Preview Oct 29, 2026 10:51pm UTC

Request Review

@ryan-roemer
ryan-roemer merged commit 5922fe0 into chore/2026-uplift-02 Oct 29, 2026
4 checks passed
@ryan-roemer
ryan-roemer deleted the fix/uplift-docs-examples-12 branch October 29, 2026 22:55
@ryan-roemer ryan-roemer mentioned this pull request Oct 29, 2026
47 of 95 tasks

This branch was successfully deployed

1 active deployment
Preview — 3bd01d14 Deployed Oct 29, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant