Repository navigation
[uplift] fix: docs example warnings and website cleanups - #3124
Merged
Merged
Conversation
|
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This branch was successfully deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
keys (error-bar, bar-horizontal-stacked)VictoryAxiswith the data dates astickValuesand a short datetickFormat. Default ticks can land on a weekend and d3fc warns; its ownscale.ticks()emits the same warning, so it can't supply them. Still two axes; tick labels now read "Jun 1" … "Jun 11"Selectrendersvalue ?? "".activeChartTypestarts asnull, which thevalue = ""default didn't catch (React warning)victory-typedocplugin (never registered) and its deps (typedoc,mdast-util-from-markdown,find-cache-dir)lodash(+@types/lodash) in the websitesrc: script renamedtypecheck→types:checkso turbo/pnpm check/CI run it (victory-docs#types:checkskips the docs build). Type-only fixes: Docusaurustypes,*.pngdeclaration,victory-core→victoryimport, droputility-types, enum casts inchart-panel,dateXcast inlanding-demo(DataGetterPropTypelacksDate)