Repository navigation
Conversation
- Cancel in the "Please continue in your web browser" box calls OnLoginComplete(UserCancelled) but left m_bWaitingLogin set, so Tick kept sending CheckLogin every second - Five minutes later the login code expires, the server answers FAILED and OnLoginComplete(Failed) pops whatever screen is on top - If the player went on to a LAN match meanwhile, that pops LanGameOptionsMenu mid-match, LanLobbyMenuInit resets TheLAN and deletes the running game, and the client crashes - OnLoginComplete now clears m_bWaitingLogin for every result
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cancelling the browser login left
m_bWaitingLoginset, soCheckLoginkept polling. Five minutes later the login code expires andOnLoginComplete(Failed)pops the screen on top. In a LAN match that is the game options screen: the LAN lobby opens, deletes the running game, and the client crashes. NowOnLoginComplete()clearsm_bWaitingLoginfor every result.Players report frequent crashes in LAN matches, five minutes after they opened Online.
Quick reproduction: move
GeneralsOnlineData/credentials.jsonout of the user data folder, press Online, then Cancel in the "Please continue in your web browser" box. Start a LAN game with a bot and stay in the match: it crashes five minutes after Online was opened. With the fix, the match keeps running.Stack trace (macOS, arm64)