Repository navigation
Migrate gallery and video player to compose - #781
Merged
thestinger merged 11 commits intoOct 20, 2026
Merged
thestinger merged 11 commits into
thestinger merged 11 commits into
Conversation
m4pl
marked this pull request as ready for review
October 19, 2026 20:56
m4pl
force-pushed
the
task/760-gallery-and-video-player-compose
branch
from
October 20, 2026 17:08
4bffec3 to
1b680e1
Compare
RankoR
approved these changes
Oct 20, 2026
sdsantos
approved these changes
Oct 21, 2026
sdsantos
left a comment
sdsantos
left a comment
There was a problem hiding this comment.
More UI notes:
- Clicking the gallery title could go directly to the folder of the content we're viewing (for example, the Camera folder, instead of the root Albums folder)
- I was seeing a different thumbnail image in the camera than the first one the gallery showed to me (it may be temporary and could already be fixed in the other PR)
- Swipe back from last image could go back to camera (optional, feature in Google Camera)
- Zoom out too much could go back to camera (optional, feature in Google Camera)
- Video playback stops when rotating screen
- Video playback could repeat at the end
- Video controls could hide automatically after the video is playing for a while
- Ripples are slightly cut in the bottom controls bar:
- If there's no thumbnail available in the main screen, maybe the button should be disabled? Can this behaviour looks a bit odd:
no_media.mp4
- Videos sometimes are taking too long to load the preview (that's a 2 second video that is loading in the video below). Maybe we're missing some loading animation if it's taking more than 500ms?
video_takes_long.mp4
| style = MaterialTheme.typography.bodyMedium, | ||
| modifier = Modifier.padding( | ||
| start = SHEET_HORIZONTAL_PADDING, | ||
| top = MESSAGE_TOP_PADDING, |
There was a problem hiding this comment.
I feel the ModalBottomSheets here have corners that are a bit too large. This makes the text starting on top a bit too close to a corner. Maybe either reduce the large and extra large corner sizes, and/or increase here the top padding a bit.
| current | extraLargeCorner=28.dp + topPadding=32.dp |
|---|---|
 |
 |
| text = label, | ||
| style = MaterialTheme.typography.labelLarge, | ||
| ) | ||
| Text( |
There was a problem hiding this comment.
I feel these values should be selectable text, at least the file path.
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Moves the gallery and video player to Compose.
Inline video, viewer gestures and undo for deletes come in the next PR.