Repository navigation
Add video player features - #791
Merged
thestinger merged 12 commits intoOct 27, 2026
Merged
thestinger merged 12 commits into
thestinger merged 12 commits into
Conversation
m4pl
marked this pull request as ready for review
October 26, 2026 21:09
RankoR
suggested changes
Oct 26, 2026
| this.stateHolder = stateHolder | ||
| } | ||
|
|
||
| override suspend fun trackPlayback() { |
Member
There was a problem hiding this comment.
Media refresh can restart playback after the gallery stops. If you open a video, switch to the system gallery and delete a video, ScreenStopped will pause playback, but ViewModel continues observing media changes. The next video occupies the settled index, triggering play, while gallery is stopped. Playback should be gated on screen lifecycle state.
| } | ||
|
|
||
| private fun play() { | ||
| setSeek( |
Member
There was a problem hiding this comment.
With looping disabled, pause, seek to the end and press play. The controller converts the held end position into Seek.Landing(end), while VideoPlaybackImpl.play() rewinds the ended player to zero. The displayed time and slider keep waiting for the old end position instead of following replay.
RankoR
approved these changes
Oct 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Updated the video player and added some optimizations.
Closes #760