Repository navigation
Conversation
Contributor
Coverage Report
File Coverage
|
||||||||||||||||||||||||||||||||||||||||||||
404oops
force-pushed
the
fix/realtime-active-eligibility
branch
from
November 1, 2026 18:26
3ed75de to
909d875
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Close only connections matching revoked session or full-access token identities and invalidate their auth cache state. Bridge the existing revocation events onto same-cluster pub/sub because raw WebSockets do not use the socket.io cluster adapter. Preserve periodic verification as the missed-event fallback.
Check paid eligibility independently of the authentication cache and after subscription invalidation. Repeated failed lookups get a retry grace. A failed check after the 60-second threshold closes with a retryable internal error instead of reporting invalid credentials. This threshold is not a wall-clock polling guarantee.
Validation: 96 relay tests pass at this layer. Tests revoke through actual auth APIs, exercise sibling-node Redis pub/sub, preserve unrelated sessions/tokens, detect downgrades with positive free credit and without another response, miss events deliberately, and simulate authentication/entitlement lookup outages.
Security: changes active credential and subscription enforcement. Already accepted billable work retains bounded settlement.
Final combined validation at
7adeb371e177a9532bac5d78a3f83318d1af4757: 625 backend tests, 122 SDK conversation/history/transport tests, 10 built-SDK mock-provider tests and 3 cross-platform API checks passed. Backend build, SDK declaration checks and lint passed; repository typecheck reports no new errors with 23 known baseline errors. No paid/live provider traffic or production rollout test was run.Stack: follow-up 4/7, overall 10/13. Based on #4453 (
fix/realtime-upgrade-admission). Review and merge bottom-up. The existing six-PR stack ends at #4441.