Skip to content

fix(logging): redact credential headers in debug output - #268

Merged
Andris28 merged 2 commits into
mainfrom
fa/redact-credential-headers
Nov 6, 2026
Merged

Andris28 merged 2 commits into
mainfrom
fa/redact-credential-headers

Conversation

@Andris28

@Andris28 Andris28 commented Nov 3, 2026

Copy link
Copy Markdown
Contributor

In this commit we fix an issue where if debug logging is enabled,
the SDK core only redacted the Authorization and X-Auth* headers.
Other credential-bearing headers were written to the debug log in clear text.

Signed-off-by: András Felleg <afelleg@gmail.com>
@Andris28
Andris28 requested a review from pyrooka November 3, 2026 11:04
@pyrooka

pyrooka commented Nov 6, 2026

Copy link
Copy Markdown
Member

Whoops, somehow my message didn't make it to the approval. Everything looks good here, thanks for the changes! :)

@Andris28
Andris28 merged commit 20febf9 into main Nov 6, 2026
15 checks passed
@Andris28
Andris28 deleted the fa/redact-credential-headers branch November 6, 2026 14:10
ibm-devx-sdk pushed a commit that referenced this pull request Nov 6, 2026
## [9.29.3](9.29.2...9.29.3) (2026-11-06)

### Bug Fixes

* **logging:** redact credential headers in debug output ([#268](#268)) ([20febf9](20febf9))
@ibm-devx-sdk

Copy link
Copy Markdown
Contributor

🎉 This PR is included in version 9.29.3 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants