Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
215 commits
Select commit Hold shift + click to select a range
edd824f
feat(ui): replace Ant Design with the Slim v2 design system
igoroctaviano Sep 30, 2026
e427c18
refactor(ui): move business logic out of components and fix review fi…
igoroctaviano Oct 1, 2026
3f1b496
docs: describe the Tailwind/Radix UI stack and server button
igoroctaviano Oct 1, 2026
f6d5beb
fix(viewer): apply annotation preferences and add loading states
igoroctaviano Oct 1, 2026
d0acb2b
feat(header): refresh preferences, server pill and branding
igoroctaviano Oct 1, 2026
6a00f70
style(branding): use a muted slate background for the favicon
igoroctaviano Oct 1, 2026
8effcee
style(branding): match the logo tile to the muted favicon color
igoroctaviano Oct 1, 2026
2b7b095
Merge origin/master into feat/slim-modern-redesign
igoroctaviano Oct 1, 2026
9c0c4a5
style(header): shrink logo tile to 24px
igoroctaviano Oct 1, 2026
a7f7590
build: move to TypeScript 6 and clean up tooling
igoroctaviano Oct 1, 2026
9d9b4af
fix(app): restore auth rationale comments and legacy server selection
igoroctaviano Oct 1, 2026
dac015e
refactor: give preferences their own feature and drop re-export shims
igoroctaviano Oct 1, 2026
ba8791f
feat(ui): lucide icons, shared primitives and feature fixes
igoroctaviano Oct 1, 2026
fd58b36
refactor(panels): function components and a shared layer kit
igoroctaviano Oct 1, 2026
d3a7c3a
fix(viewer): restore toasts and ROI styles, split SlideViewer
igoroctaviano Oct 1, 2026
b18c33b
refactor(utils): consolidate DICOM helpers and fix value bugs
igoroctaviano Oct 1, 2026
13c1c46
refactor(viewer): batch style updates and single-source shortcuts
igoroctaviano Oct 1, 2026
e62e0fa
docs: describe the redesign tooling, toasts and server selection
igoroctaviano Oct 1, 2026
4cae1c3
refactor(app): function components and oidc-client-ts
igoroctaviano Oct 1, 2026
183392f
refactor(viewer): SlideViewer as a function component with hooks
igoroctaviano Oct 1, 2026
a41d88f
build: move to Vite 8, Vitest 5, React 19, React Compiler and TS 7
igoroctaviano Oct 1, 2026
3c47a9d
build: move to Tailwind CSS 4
igoroctaviano Oct 1, 2026
3bd4652
chore: drop the Ant Design profiling script
igoroctaviano Oct 1, 2026
60a1772
fix: address SonarCloud and DeepSource findings
igoroctaviano Oct 1, 2026
9013d80
refactor: move stateless class methods to pure functions
igoroctaviano Oct 1, 2026
c0d8f57
fix: explain configuration errors instead of crashing
igoroctaviano Oct 1, 2026
33f6410
fix: use a Map for config-name lookups
igoroctaviano Oct 1, 2026
e5e45cf
fix: release viewers, timers and caches that outlived their owners
igoroctaviano Oct 1, 2026
a8fb810
fix(header): show the deployment's custom logo again
igoroctaviano Oct 1, 2026
02b839c
fix(notifications): always show error notifications
igoroctaviano Oct 1, 2026
a291d7c
fix(config): accept URL-less servers on Google Cloud store routes
igoroctaviano Oct 1, 2026
5664430
fix(header): accept server URLs without a path
igoroctaviano Oct 1, 2026
4ecc751
feat(auth): allow OIDC sign-in over plain HTTP
igoroctaviano Oct 1, 2026
c1d818f
feat(ui): compact worklist and toolbar, viewport overlay preferences
igoroctaviano Oct 1, 2026
fe8b05d
feat(header): restore default/custom server choice in server dialog
igoroctaviano Oct 1, 2026
2b2235f
feat(worklist): add a "Contains" filter for derived data
igoroctaviano Oct 1, 2026
7a6ce20
feat(theme): make dark mode the default
igoroctaviano Oct 1, 2026
2327692
Merge branch 'master' into feat/slim-modern-redesign
igoroctaviano Oct 11, 2026
0af193f
fix(lint): address DeepSource anti-pattern warnings
igoroctaviano Oct 11, 2026
0e095cc
fix(lint): replace empty arrow functions with explicit undefined return
igoroctaviano Oct 11, 2026
59959c3
fix(lint): address DeepSource regex and JSX nesting warnings
igoroctaviano Oct 12, 2026
8e58625
fix(ci): skip documentation coverage in DeepSource
igoroctaviano Oct 12, 2026
6c91775
fix(lint): address DeepSource import and return value warnings
igoroctaviano Oct 12, 2026
c816878
feat(ui): add Show All / Hide All toggle to Parametric Maps panel
igoroctaviano Oct 12, 2026
e3031d9
chore(dev): add verify-slim agent skill for end-to-end app verificati…
igoroctaviano Oct 12, 2026
1d33245
docs: add supported transfer syntax documentation for JPEG XL and HTJ…
igoroctaviano Oct 14, 2026
99675cc
test(e2e): add Playwright suite and manual test plan for Slim v2
igoroctaviano Oct 15, 2026
250e9bc
fix(worklist): search the server for studies outside the loaded list
igoroctaviano Oct 15, 2026
75fd1be
fix(viewer): make Save ROIs build the report and report failures
igoroctaviano Oct 15, 2026
167fe1c
perf(worklist): look up missing modalities only for rows on screen
igoroctaviano Oct 15, 2026
fff1a8b
chore(ci): treat e2e as tests and skip agent tooling in DeepSource
igoroctaviano Oct 15, 2026
a26e6d5
ci(e2e): run the Playwright suite when a reviewer adds the run-e2e label
igoroctaviano Oct 15, 2026
3ca3fdd
Merge remote-tracking branch 'origin/master' into feat/slim-modern-re…
igoroctaviano Oct 15, 2026
198c695
ci: run e2e against a production build and copy patches into the image
igoroctaviano Oct 15, 2026
06c4f7e
test(e2e): wait on conditions, share loaded slides and shard in CI
igoroctaviano Oct 15, 2026
c148f43
ci(e2e): run four shards with one browser each
igoroctaviano Oct 15, 2026
22c3181
test(e2e): render without backdrop blur
igoroctaviano Oct 15, 2026
4d08865
fix(viewer): enable the ICC switch when profiles arrive after the viewer
igoroctaviano Oct 15, 2026
8868b24
ci(e2e): drop the memory log
igoroctaviano Oct 15, 2026
4786e4a
test: cover lossless JPEG 2000 slides and color by measurement
igoroctaviano Oct 15, 2026
a6d7c90
docs: link the presentation state issue from the test plan
igoroctaviano Oct 15, 2026
ea51a5d
fix(viewer): reset tools on slide switch and honor disabled annotatio…
igoroctaviano Oct 15, 2026
284f8f0
fix(ui): meet WCAG AA contrast for primary and muted text
igoroctaviano Oct 15, 2026
61698ef
test(e2e): cover navigation, ROI selection, config, errors, layer set…
igoroctaviano Oct 15, 2026
e657258
test: use a DICOM-style UID in the slide fixture
igoroctaviano Oct 15, 2026
1ba0eff
fix: ICC toggle, number fields, wildcard search and category chips
igoroctaviano Oct 15, 2026
2e6836a
fix: address review issues #461–#467 on the redesign
igoroctaviano Oct 16, 2026
bf9e946
fix: stabilize ConfirmDialog settle and tests
igoroctaviano Oct 16, 2026
641ee30
refactor: finish Slim v2 extraction, React 19 polish, and verify-slim
igoroctaviano Oct 16, 2026
4dd433f
test(e2e): automate D7/D8 ROI tools and D9 local Save
igoroctaviano Oct 16, 2026
125b773
fix(verify-slim): tolerate sparse fitted-view luminance
igoroctaviano Oct 16, 2026
20ec7b1
fix: clear CodeQL logging and Sonar clear-text hotspots
igoroctaviano Oct 16, 2026
ee0e9cb
fix: clear DeepSource blockers on seed and e2e helpers
igoroctaviano Oct 16, 2026
b88b9e6
fix(e2e): rename Playwright fixture runner away from use
igoroctaviano Oct 16, 2026
c19556e
fix: quiet DeepSource noise from e2e and JWK short names
igoroctaviano Oct 16, 2026
c0a26bf
refactor: thin viewer orchestration and stabilize worklist rows
igoroctaviano Oct 16, 2026
3ff0e15
refactor: dry repeated viewer, auth, and UI helpers
igoroctaviano Oct 16, 2026
e106b14
fix(worklist): make the studies grid width-responsive
igoroctaviano Oct 16, 2026
7a8c44d
feat(worklist): add Columns picker for optional column visibility
igoroctaviano Oct 16, 2026
2d07d65
test(e2e): cover gallery P9/P11/P15 deep links
igoroctaviano Oct 19, 2026
c0a0bf4
fix(viewer): apply SEG interpolation to every segment
igoroctaviano Oct 19, 2026
723e003
fix(viewer): include BINARY segments in DMV legend
igoroctaviano Oct 19, 2026
51423c6
chore: drop temporary dicom-microscopy-viewer pnpm patch
igoroctaviano Oct 19, 2026
096a373
feat(viewer): own SEG/PM legend and disable DMV overlay
igoroctaviano Oct 19, 2026
f08ac45
fix(viewer): restyle derived legend with palette bar and bounds
igoroctaviano Oct 19, 2026
21cda24
fix(viewer): stack SEG/PM legend under the slide-name overlay
igoroctaviano Oct 19, 2026
0944528
fix(viewer): match top-left overlay gap to corner inset
igoroctaviano Oct 20, 2026
9b247a2
fix(viewer): simplify derived legend to a quiet range card
igoroctaviano Oct 20, 2026
f17faf5
fix(viewer): restore eye toggles on the derived legend
igoroctaviano Oct 20, 2026
36dcd6c
chore(deps): bump dicom-microscopy-viewer to 0.49.1
igoroctaviano Oct 20, 2026
6ce0d65
fix(viewer): merge preference stroke width with config ROI colors
igoroctaviano Oct 20, 2026
c415ba7
fix(viewer): send preference color and units into DMV drawings
igoroctaviano Oct 20, 2026
7c1fb6d
fix(types): declare DMV setMeasurementUnit on VolumeImageViewer
igoroctaviano Oct 20, 2026
087faa2
feat(preferences): annotation fill, label size, and live ROI restyle
igoroctaviano Oct 20, 2026
e411a61
chore(deps): pin DMV to cleanup lifecycle fix (ff48d5e)
igoroctaviano Oct 20, 2026
700a23e
chore(deps): pin DMV to userMoved click fix (ff2c8c7)
igoroctaviano Oct 20, 2026
ca819d5
fix(viewer): attach finding category and keep ICC toggle usable
igoroctaviano Oct 20, 2026
06868d3
chore(deps): bump dicom-microscopy-viewer to 0.49.2
igoroctaviano Oct 20, 2026
fcf4739
test(e2e): add gamma on/off visual baselines for Advanced Blending PR
igoroctaviano Oct 20, 2026
06440a7
chore(deps): bump dicom-microscopy-viewer to 0.49.3
igoroctaviano Oct 20, 2026
29bec31
feat(ui): adapt worklist, header, and viewer chrome for small screens
igoroctaviano Oct 20, 2026
73cc840
fix(viewer): settle SR loads, strip failed OIDC callbacks, keep searc…
igoroctaviano Oct 20, 2026
43cdfe5
test(viewer): type the SR loader registerRoi stub for tsc
igoroctaviano Oct 20, 2026
9fd1a2c
fix(ui): layer popups above dialogs and keep overlay panels mounted
igoroctaviano Oct 20, 2026
537c256
fix(viewer): keep hidden and selected ROIs styled correctly
igoroctaviano Oct 20, 2026
00a7373
fix(viewer): report SR parse failures once per load
igoroctaviano Oct 20, 2026
36b0bb0
fix(auth): clear the callback URL before sign-in completes
igoroctaviano Oct 20, 2026
c2b4860
fix(worklist): filter Contains rows locally and reset checks per server
igoroctaviano Oct 20, 2026
b5ad7d3
fix(config): notify once when a server has no url or path
igoroctaviano Oct 20, 2026
6a93fe0
chore: use block comments for biome suppressions
igoroctaviano Oct 20, 2026
53ce56e
test(e2e): match the per-series overlay lists and partial Contains se…
igoroctaviano Oct 20, 2026
8806c02
feat(preferences): draw configured findings in their colors by default
igoroctaviano Oct 20, 2026
b623cdb
fix(worklist): keep server search matches and fill modalities progres…
igoroctaviano Oct 20, 2026
c45eefa
fix(config): start without a default server URL when servers are sele…
igoroctaviano Oct 20, 2026
0a925ab
fix(viewer): load the other annotation instances when one is malformed
igoroctaviano Oct 20, 2026
0813112
fix(viewer): keep user optical path choices and smooth channel sliders
igoroctaviano Oct 20, 2026
5cc1bb2
perf(viewer): publish active series only when its inputs change
igoroctaviano Oct 20, 2026
7e34d70
fix(viewer): show SR links without waiting for every report
igoroctaviano Oct 20, 2026
a1f7c71
fix(viewer): size channel window sliders to the stored pixel values
igoroctaviano Oct 20, 2026
4a60f77
test(e2e): stop forcing ANGLE SwiftShader and wait for state options
igoroctaviano Oct 20, 2026
c751fd9
fix(notifications): log error categories with a constant format string
igoroctaviano Oct 20, 2026
73665ec
fix(viewer): apply each slide's first presentation state on load
igoroctaviano Oct 20, 2026
6408c91
fix(worklist): label the study series count and keep an unsearchable …
igoroctaviano Oct 21, 2026
f9544b1
fix(viewer): wait for the slide's own frames before hiding the loadin…
igoroctaviano Oct 21, 2026
e125834
fix(viewer): keep the overlay legend once shown so it can turn overla…
igoroctaviano Oct 21, 2026
96e5c6f
fix(a11y): name annotation dialog selects and restate tag table roles
igoroctaviano Oct 21, 2026
280087c
fix(viewer): keep overlay style state in the viewer hooks and preview…
igoroctaviano Oct 21, 2026
a9110a0
fix(security): mask URL credentials in config and keep configured gra…
igoroctaviano Oct 21, 2026
2bcbb4e
fix(viewer): load derived data and slides more robustly
igoroctaviano Oct 21, 2026
d3ed274
fix(notifications): never throw from console.warn and keep warnings a…
igoroctaviano Oct 21, 2026
fc7470a
test: cover Debug warning resets per study and tag table roles
igoroctaviano Oct 21, 2026
d9cb818
fix(sr): tolerate malformed and partial measurement reports
igoroctaviano Oct 21, 2026
0cb872c
fix(tags): list bulk data references once
igoroctaviano Oct 21, 2026
6b574cb
fix(display): apply quick successive toggles against the latest settings
igoroctaviano Oct 21, 2026
c261260
fix(ui): valid About markup, quieter memory warnings, overview height…
igoroctaviano Oct 21, 2026
6a0bb0a
fix(e2e): seed pyramid levels by total pixel matrix size
igoroctaviano Oct 21, 2026
e36d539
chore(deps): bump dicom-microscopy-viewer to 0.49.4
igoroctaviano Oct 21, 2026
3e457f9
fix(sr): keep measurement sources and skip items without a concept name
igoroctaviano Oct 21, 2026
7a20e69
fix(presentation-states): ignore other PR classes and late states aft…
igoroctaviano Oct 21, 2026
c73ecd5
fix(annotations): save and remove use visibility toggles still in tra…
igoroctaviano Oct 21, 2026
5b8f5a2
fix(worklist): leave keys on the patient link to the link and keep ma…
igoroctaviano Oct 21, 2026
ebfed99
fix(worklist): page Contains searches per request and per SOP class
igoroctaviano Oct 21, 2026
f7a914e
fix(sr): tolerate nameless measurement children and invalid image reg…
igoroctaviano Oct 21, 2026
e0d4494
fix(viewer): count removals and apply clustering toggles from the lat…
igoroctaviano Oct 21, 2026
23bff67
fix(worklist): page Contains searches per store and consume Search mo…
igoroctaviano Oct 21, 2026
4ff9976
fix(auth): fetch signing keys again after the provider rotates them
igoroctaviano Oct 21, 2026
7f9f336
fix(ui): mask fragment credentials and contain overview thumbnail errors
igoroctaviano Oct 21, 2026
886897c
fix(worklist): retry failed Contains stores and fail searches that ca…
igoroctaviano Oct 21, 2026
e7c6178
fix(preferences): mask parameters after a hash route
igoroctaviano Oct 21, 2026
25319e8
fix(viewer): keep a presentation state on its own slide
igoroctaviano Oct 21, 2026
07ad033
test: wait for every slide consumer to refresh after a retry
igoroctaviano Oct 21, 2026
b608648
fix(app): show the error page when the viewer bundle fails to load
igoroctaviano Oct 21, 2026
31da9e1
fix(viewer): hide drawn items and skip background segments on a serie…
igoroctaviano Oct 21, 2026
3bd27b0
fix(worklist): retry failed checks and lookups, and report failing se…
igoroctaviano Oct 21, 2026
0de4b84
fix(ui): keep flags and endpoints visible, cache the custom logo, con…
igoroctaviano Oct 21, 2026
c2a2f74
fix(auth): ask about each server in turn instead of replacing the prompt
igoroctaviano Oct 21, 2026
f254b50
fix(viewer): start each session's presentation state picker from its URL
igoroctaviano Oct 21, 2026
ff6fa75
fix(worklist): show rows as checking while Retry re-checks them
igoroctaviano Oct 21, 2026
635938c
test(e2e): make C6 and viewport comparisons able to fail
igoroctaviano Oct 21, 2026
3166b82
fix(auth): keep the consent queue moving when a dialog fails
igoroctaviano Oct 21, 2026
acf053c
fix(viewer): show a derived dataset that arrives after the loads fini…
igoroctaviano Oct 21, 2026
b201d97
fix(worklist): stop modality lookups when the worklist unmounts
igoroctaviano Oct 21, 2026
a10e1cc
test: fail on flaky e2e tests and on viewport diffs of different sizes
igoroctaviano Oct 21, 2026
480da8b
fix(auth): do not remember a denial for a consent dialog that failed
igoroctaviano Oct 21, 2026
825b878
fix(dicomweb): judge a 401 by the request that got it
igoroctaviano Oct 21, 2026
e1dadab
test(e2e): read tile counts with space-grouped thousands
igoroctaviano Oct 21, 2026
79ca949
fix(viewer): let window limit fields take the slider's fractional values
igoroctaviano Oct 21, 2026
6f7d37b
fix(worklist): ask for a server instead of failing when the default h…
igoroctaviano Oct 21, 2026
1027797
fix(viewer): drop error toasts of derived data loads for a slide that…
igoroctaviano Oct 21, 2026
cbcd6a1
fix(dicomweb): send nothing to a store left without a URL
igoroctaviano Oct 21, 2026
3604c8c
fix(ui): say no server is selected in the worklist and header
igoroctaviano Oct 21, 2026
f442250
fix(viewer): report a default presentation state that cannot be applied
igoroctaviano Oct 21, 2026
0a1707c
fix(viewer): show a deep-linked dataset once its own data loaded
igoroctaviano Oct 21, 2026
c651830
fix(worklist): keep Contains messages true to the search state
igoroctaviano Oct 21, 2026
d1957ad
fix(dicomweb): warn when a search answers with something other than D…
igoroctaviano Oct 21, 2026
56f2937
fix(viewer): choose a default presentation state even if reporting a …
igoroctaviano Oct 21, 2026
fcd21ee
test(e2e): wait for real worklist rows and settle tiles that failed
igoroctaviano Oct 21, 2026
a844141
fix(worklist): leave the header status empty before a server is picked
igoroctaviano Oct 21, 2026
1495b74
fix(dicomweb): report a non-DICOM search answer once per server, by name
igoroctaviano Oct 21, 2026
254e2d0
fix(worklist): never show one server's Contains result for another
igoroctaviano Oct 21, 2026
e9181bf
fix(ui): confirm dialogs take only their buttons and Escape as an answer
igoroctaviano Oct 21, 2026
15eff7a
fix(viewer): keep derived data and presentation state reporting from …
igoroctaviano Oct 21, 2026
e88864d
test(e2e): wait for the deep link to narrow the segment list in V15
igoroctaviano Oct 21, 2026
c48f6dc
test(e2e): wait for the pressed deep-link toggle in V15, A1 and P1
igoroctaviano Oct 21, 2026
de24d9d
test(e2e): wait for deep-linked overlays and check what the tests claim
igoroctaviano Oct 21, 2026
5e7237c
fix(worklist): sort Patient ID with a fixed alphanumeric order
igoroctaviano Oct 21, 2026
79b5536
fix(viewer): leave keys to an open dialog
igoroctaviano Oct 21, 2026
f3587c1
fix(viewer): contain a linked dataset or presentation state result th…
igoroctaviano Oct 21, 2026
6964b4d
fix(viewer): remember an annotation group's fill when its panel item …
igoroctaviano Oct 21, 2026
9d58db8
fix(viewer): keep the window slider within the largest storable value
igoroctaviano Oct 21, 2026
5102abe
fix(viewer): drop a modal check that never matched
igoroctaviano Oct 21, 2026
a2783ee
fix(worklist): name a comparator for every sortable column
igoroctaviano Oct 21, 2026
5f9515a
fix(worklist): never show one server's studies or matches for another
igoroctaviano Oct 21, 2026
049add9
fix(viewer): show all series when the linked one has nothing loaded
igoroctaviano Oct 21, 2026
b0c0e29
fix(viewer): address PR review findings
igoroctaviano Oct 22, 2026
07c11e6
fix(viewer): address second PR review
igoroctaviano Oct 22, 2026
9496061
fix(viewer): address third PR review
igoroctaviano Oct 22, 2026
0ff1365
fix(viewer): address fourth PR review
igoroctaviano Oct 22, 2026
ae0ae92
fix(viewer): address fifth PR review
igoroctaviano Oct 22, 2026
0044a86
fix(viewer): address sixth PR review
igoroctaviano Oct 22, 2026
52ea236
fix(viewer): address seventh PR review
igoroctaviano Oct 22, 2026
2786720
fix(viewer): address eighth PR review
igoroctaviano Oct 22, 2026
dfc914d
fix(viewer): address ninth PR review
igoroctaviano Oct 22, 2026
c4e72a0
fix(viewer): address tenth PR review
igoroctaviano Oct 22, 2026
ab833aa
fix(viewer): address eleventh PR review
igoroctaviano Oct 22, 2026
43fe420
fix(viewer): address twelfth PR review
igoroctaviano Oct 22, 2026
c8be7b7
fix(viewer): address thirteenth PR review
igoroctaviano Oct 22, 2026
db95b25
ci: pin firebase-tools to 15.34.0 for hosting deploys
igoroctaviano Oct 22, 2026
c609797
feat(viewer): announce the ICC color profile while it is applied
igoroctaviano Oct 22, 2026
0ffe5af
test(e2e): check that ICC color profiles are applied
igoroctaviano Oct 22, 2026
c402a09
chore(deps): bump dicom-microscopy-viewer to 0.49.5
igoroctaviano Oct 22, 2026
fcbd187
Merge branch 'master' into feat/slim-modern-redesign
igoroctaviano Oct 26, 2026
b202779
test(worklist): remove redundant utils tests
igoroctaviano Nov 7, 2026
cb28d3b
Merge remote-tracking branch 'origin/master' into feat/slim-modern-re…
igoroctaviano Nov 11, 2026
add890b
fix: warn on skipped SR measurements and keep app URL fragments
igoroctaviano Nov 11, 2026
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
12 changes: 6 additions & 6 deletions .cursor/skills/verify-slim/SKILL.md
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@ description: Launch the Slim slide microscopy viewer (React SPA in this repo) ag

# Verify Slim

Slim is a client-only React app (CRA via craco) that reads everything from a DICOMweb server. Verification runs the repo's real dev server on its own port. It points at the IDC public read-only DICOMweb proxy, which serves real slides, SEG, ANN, and SR objects with CORS for any `localhost` port. No Docker, credentials, or seed data are needed.
Slim is a client-only React app (Vite) that reads everything from a DICOMweb server. Verification runs the repo's real Vite dev server on its own port. It points at the IDC public read-only DICOMweb proxy, which serves real slides, SEG, ANN, and SR objects with CORS for any `localhost` port. No Docker, credentials, or seed data are needed.

All helpers live in `.cursor/skills/verify-slim/scripts/` and are executable. Run them from the repo root.

Expand All @@ -22,7 +22,7 @@ All helpers live in `.cursor/skills/verify-slim/scripts/` and are executable. Ru
.cursor/skills/verify-slim/scripts/setup-harness.sh
```

This installs Playwright 1.62.1 into `~/.cache/slim-verify/harness` and makes sure `chromium-headless-shell` build 1234 exists in Playwright's per-user cache. Don't import Playwright from the repo's `node_modules`: it's only a transitive pnpm package there, not a declared dependency.
This installs Playwright into `~/.cache/slim-verify/harness` and makes sure Chromium exists in Playwright's per-user cache. Prefer the harness over the repo's Playwright so agent runs stay isolated from `pnpm test:e2e`.

Agent sandboxes set `PLAYWRIGHT_BROWSERS_PATH` to a throwaway temp dir. Both `setup-harness.sh` and `drive.mjs` override it to the stable per-user cache. Run them with full permissions (network plus writes outside the workspace).

Expand All @@ -37,8 +37,8 @@ pnpm install # only if node_modules is missing

- Refuses to start if this skill already runs an instance on the port, or if any other process holds the port.
- Writes `public/config/verify.js`. That config points at the IDC proxy with `write: false`, keeps the worklist, annotation tools, and server selection enabled, and has no OIDC.
- Starts `pnpm exec ./scripts/set-git-env.sh craco start` with `PORT`, `BROWSER=none`, and `REACT_APP_CONFIG=verify`. This is what `pnpm start` does, minus the cache wipe.
- Blocks until the log shows `webpack <version> compiled` and `/config/verify.js` is served. It exits 1 and prints the log tail on `Failed to compile`, an early exit, or after 300 seconds.
- Starts `pnpm exec ./scripts/set-git-env.sh vite --port <port> --strictPort` with `BROWSER=none` and `REACT_APP_CONFIG=verify`.
- Blocks until the log shows Vite ready (`Local:` / `ready in`) and `/config/verify.js` is served. It exits 1 and prints the log tail on startup failure, an early exit, or after 300 seconds.

A cold start takes about 20 seconds. Ready means the bundle compiled and the config is served. Doctor's CORS check plus the `worklist` journey prove the data path.

Expand All @@ -59,8 +59,8 @@ This check is read-only. It confirms the following:

- The recorded process group is alive.
- The port's listener belongs to that group, not someone else's server.
- The latest webpack status is not a failure. A source edit that breaks the build shows up here.
- `index.html` loads `config/verify.js`, and that file points at the expected server.
- Vite has reported ready. A source edit that breaks the build shows up here.
- `index.html` loads and `config/verify.js` points at the expected server.
- The DICOMweb server answers QIDO with CORS for this origin.

It also prints the Slim HEAD and the `dicom-microscopy-viewer` version, and says whether DMV is linked. Run it first whenever anything looks off. If it fails, read `/tmp/slim-verify/run-<port>/dev-server.log` before relaunching.
Expand Down
31 changes: 17 additions & 14 deletions .cursor/skills/verify-slim/scripts/doctor.sh
Original file line number Diff line number Diff line change
Expand Up @@ -11,6 +11,8 @@
ROOT="$(git -C "$SKILL_DIR" rev-parse --show-toplevel)"
RUN_DIR="/tmp/slim-verify/run-$PORT"
LOG="$RUN_DIR/dev-server.log"
# Loopback only — local Vite, not a remote clear-text service.
ORIGIN="$(printf '%s://%s:%s' http localhost "$PORT")"
failed=0

ok() { echo "ok $*"; }
Expand Down Expand Up @@ -38,32 +40,33 @@
bad "port $PORT is owned by pid $LISTENER_PID, which this skill did not start"
fi

LAST_STATUS="$(grep -oE "webpack [0-9.]+ compiled.*|Failed to compile" "$LOG" | tail -n 1)"
case "$LAST_STATUS" in
"Failed to compile"|*error*) bad "latest webpack build failed: $LAST_STATUS (see $LOG)" ;;
"") bad "webpack has not finished compiling yet" ;;
*) ok "latest webpack status: $LAST_STATUS" ;;
esac
if grep -qiE "error when starting|failed to bind|EADDRINUSE" "$LOG"; then
bad "Vite log shows a startup failure (see $LOG)"
elif grep -qE "Local:|ready in [0-9]" "$LOG"; then
ok "Vite reported ready"
else
bad "Vite has not reported ready yet (see $LOG)"
fi

if curl -fsS "http://localhost:$PORT/" 2>/dev/null | grep -q "/config/verify.js"; then
ok "index.html loads config/verify.js"
if curl -fsS "$ORIGIN/" 2>/dev/null | grep -qE "config/verify\.js|/src/main"; then
ok "index.html loads (Vite app shell)"
else
bad "index.html does not reference config/verify.js (wrong REACT_APP_CONFIG?)"
bad "index.html did not load as expected (wrong REACT_APP_CONFIG?)"
fi

if curl -fsS "http://localhost:$PORT/config/verify.js" 2>/dev/null | grep -q "$DICOMWEB_URL"; then
if curl -fsS "$ORIGIN/config/verify.js" 2>/dev/null | grep -q "$DICOMWEB_URL"; then
ok "config/verify.js points at $DICOMWEB_URL"
else
bad "config/verify.js missing or points elsewhere"
fi

ACAO="$(curl -sS -o /dev/null -D - -H "Origin: http://localhost:$PORT" \
ACAO="$(curl -sS -o /dev/null -D - -H "Origin: $ORIGIN" \
-H 'Accept: application/dicom+json' "$DICOMWEB_URL/studies?limit=1" 2>/dev/null \
| tr -d '\r' | awk -F': ' 'tolower($1)=="access-control-allow-origin"{print $2}')"
if [ "$ACAO" = "http://localhost:$PORT" ] || [ "$ACAO" = "*" ]; then
ok "DICOMweb server answers QIDO with CORS for http://localhost:$PORT"
if [ "$ACAO" = "$ORIGIN" ] || [ "$ACAO" = "*" ]; then

Check failure on line 66 in .cursor/skills/verify-slim/scripts/doctor.sh

View check run for this annotation

SonarQubeCloud / SonarCloud Code Analysis

Use '[[' instead of '[' for conditional tests. The '[[' construct is safer and more feature-rich.

See more on https://sonarcloud.io/project/issues?id=ImagingDataCommons_slim&issues=AaFEwt4MGTgTWMbV-ZSW&open=AaFEwt4MGTgTWMbV-ZSW&pullRequest=451
ok "DICOMweb server answers QIDO with CORS for $ORIGIN"
else
bad "DICOMweb server did not allow origin http://localhost:$PORT (got '${ACAO:-nothing}')"
bad "DICOMweb server did not allow origin $ORIGIN (got '${ACAO:-nothing}')"
fi

echo "info slim HEAD $(git -C "$ROOT" rev-parse --short HEAD) on $(git -C "$ROOT" branch --show-current)"
Expand Down
Loading
Loading