Skip to content

fix(deps): update follow-redirects to address high security vulnerabilities - #468

Merged
igoroctaviano merged 2 commits into
masterfrom
fix/dependabot-follow-redirects-1.16.1
Oct 26, 2026
Merged

igoroctaviano merged 2 commits into
masterfrom
fix/dependabot-follow-redirects-1.16.1

Conversation

@igoroctaviano

@igoroctaviano igoroctaviano commented Oct 26, 2026 •

Copy link
Copy Markdown
Collaborator

Fixes the open high-severity Dependabot alerts by overriding the transitive dependency in pnpm-workspace.yaml:

Package From To Advisories
follow-redirects 1.16.0 1.16.1 GHSA-q3jh-wrc6-jgq8, GHSA-8r9p-f939-6h3c

Only pnpm-workspace.yaml and pnpm-lock.yaml change. pnpm typecheck and pnpm test pass.

It also pins firebase-tools to 15.34.0 in the Firebase deploy workflow (same commit as on #451). Version 15.34.1 checks the Service Usage API, which the deploy service account can't read, so the preview deploy failed with HTTP 403.

@github-actions

Copy link
Copy Markdown

📦 Firebase Preview - Using Published DMV

This preview is using the published dicom-microscopy-viewer from package.json:

Version ^0.49.0

To link a DMV branch for testing (requires an open PR in DMV):

  • Add dmv-branch: <branch-name> to the PR description, OR
  • Use the same branch name in both repos (automatic matching)

@deepsource-io

deepsource-io Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

DeepSource Code Review

We reviewed changes in f10a6bc...ae001eb on this pull request. Below is the summary for the review, and you can see the individual issues we found as inline review comments.

See full review on DeepSource ↗

PR Report Card

Overall Grade   Security  

Reliability  

Complexity  

Hygiene  

Code Review Summary

Analyzer Status Updated (UTC) Details
JavaScript Oct 26, 2026 4:35p.m. Review ↗

Important

AI Review is run only on demand for your team. We're only showing results of static analysis review right now. To trigger AI Review, comment @deepsourcebot review on this thread.

firebase-tools 15.34.1 queries the Service Usage API before deploying,
which the deploy service account is not allowed to read, so every
preview deploy fails with HTTP 403.
@sonarqubecloud

Copy link
Copy Markdown

@github-actions

github-actions Bot commented Oct 26, 2026 •

Copy link
Copy Markdown

Visit the preview URL for this PR (updated for commit ae001eb):

https://idc-external-006--pr468-fix-dependabot-follo-gl2nxwey.web.app

(expires Mon, 02 Nov 2026 16:39:40 GMT)

🔥 via Firebase Hosting GitHub Action 🌎

Sign: 88aacecd98ba54d2f9c8d201a9444e43d1ad8307

@igoroctaviano
igoroctaviano merged commit b8f8066 into master Oct 26, 2026
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant