Repository navigation
Conversation
|
Build size and comparison to main:
|
FintasticMan
left a comment
FintasticMan
left a comment
There was a problem hiding this comment.
I think this is very useful, thanks!
ca33109 to
4eeadff
Compare
|
I think you could use the You can find it in |
|
@minacode the badly-named |
|
Oh, ok. Maybe we should rename it to something like Do you think you could still extract an abstract component from your implementation? I could imagine that an actual checkbox list is common enough. Maybe it doesn't make sense though. That would be ok. I am just asking. |
a02aef7 to
039506d
Compare
No, the name is based on the lvgl library, which uses checkbox as the naming. There is no radio component in lvgl, so the checkboxlist class emulates the radio behaviour by re-theming the checkboxes and overriding the select mechanism.
I did an initial PoC, but it means that now CheckboxList needs to return arrays of settings, whether it's a checkbox or a radio. This and the additional code required to make that work makes the entire thing to complex/bloated.
I can poke at it some more at another time, but likely out of scope for this PR. |
|
Ok, nice. Thanks for the detailed answer. Given that, I think your PR is fine the way it is now :) |
|
I've added new commits for configurable widgets on the Analog watch face. Attached screenshots to the description on top. |
d54ae36 to
168d9ca
Compare
49d5ec3 to
efdeebf
Compare
efdeebf to
8f10997
Compare
8f10997 to
eb9e02b
Compare
eb9e02b to
a673de8
Compare
a673de8 to
8e10a2d
Compare
8e10a2d to
c70d185
Compare
c70d185 to
291920e
Compare
5f365d9 to
42bc7d6
Compare
42bc7d6 to
3f8361a
Compare
7e62cde to
3fda05d
Compare
e103584 to
7ceabe5
Compare
7ceabe5 to
1edadc8
Compare
65e001a to
793aa10
Compare
84eaa72 to
67b2362
Compare
67b2362 to
714d612
Compare
714d612 to
cc66a8d
Compare
aeb33f0 to
5a0ad54
Compare
* settings: Add global widget selection Instead of each watch face implementing their own settings for which widgets to display, we can have a global selection of widgets. All watch faces can then determine whether it is enabled and so display it in whichever way makes sense for that face. Current widgets supported are heart rate, step counter, and weather. * WatchFaceAnalog: Add configurable widgets * WatchFaceAnalog: Add weather widget --------- Co-authored-by: Victor Kareh <vkareh@redhat.com>
5a0ad54 to
ee68093
Compare
ee68093 to
1427460
Compare
|
I'd like to review and merge this - could you pull in changes for the watchfaces that have just been merged? (might apply to legend only actually) |
087050f to
98b0c83
Compare
|
@mark9064 - done. I've rebased and Legend now supports widget selection |
98b0c83 to
44fc336
Compare
Instead of each watch face implementing their own settings for which widgets to display, we can have a global selection of widgets. All watch faces can then determine whether it is enabled and so display it in whichever way makes sense for that face. Current widgets supported are heart rate, step counter, and weather.
44fc336 to
b625dec
Compare
mark9064
left a comment
mark9064
left a comment
There was a problem hiding this comment.
Since this is a moderately sized change, I will leave this for a little while for the team to review if they wish. This is on my radar for release though :)
Instead of each watch face implementing their own settings for which widgets to display, we can have a global selection of widgets. All watch faces can then determine whether it is enabled and so display it in whichever way makes sense for that face.
Current widgets supported are heart rate, step counter, and weather.
Widgets off:
Widgets on:
