Repository navigation
Show real testset durations on Julia 1.13 - #138
Merged
Merged
Conversation
On Julia 1.13 `DefaultTestSet.time_start` is `const`, so the 1.8-1.12 approach of overwriting it before `finish` is skipped and `display_reporting_testset` reported only the display overhead in the Time column (e.g. `0.1s` for a testset whose `time_taken` was 1660ms). Pass a back-dated `time_start`, derived from the `ReportingTestSet`'s `time_taken`, to the `DefaultTestSet` constructor instead, which accepts it as a keyword on 1.13. XML output is unaffected since it reads `time_taken` directly. Co-Authored-By: Claude Opus 5.5 (claude-opus-5-5) <noreply@anthropic.com>
kleinschmidt
approved these changes
Oct 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow up to #137
With this PR the timing is captured:
With just #137 the output was: