Skip to content

fix(deps): bump golang.org/x/net to v0.62.0 (GO-2026-6860, GO-2026-6866) - #2299

Merged
IAmJSD merged 1 commit into
LeanerCloud:mainfrom
IAmJSD:fix/xnet-062
Oct 28, 2026
Merged

IAmJSD merged 1 commit into
LeanerCloud:mainfrom
IAmJSD:fix/xnet-062

Conversation

@IAmJSD

@IAmJSD IAmJSD commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Why

govulncheck (v1.1.4, module-level results) flags golang.org/x/net@v0.61.0 for GO-2026-6860 and GO-2026-6866. Both are fixed in v0.62.0. This is the same bump as LeanerCloud/cloud-commitments-platform#1564.

What

  • go get golang.org/x/net@v0.62.0 && go mod tidy
  • Only go.mod / go.sum change: x/net v0.61.0 -> v0.62.0 (indirect). Nothing else moves.

Verification

Run locally with go1.26.10 (GOTOOLCHAIN=auto), AWS_CONFIG_FILE=/dev/null AWS_SHARED_CREDENTIALS_FILE=/dev/null AWS_EC2_METADATA_DISABLED=true:

  • go build -o /dev/null ./...: OK. (A plain go build ./... fails with build output "cmd" already exists and is a directory on main too. The module has one main package, ./cmd, and the CLI builds via go build -o cudly ./cmd.)
  • go vet ./...: OK
  • go test -short -count=1 ./...: ok github.com/LeanerCloud/cloud-commitments-cli/cmd. The first run had a timing flake in TestRDSFamilyExpiryCommand/control-replacement-outside-lookback (expected 12 calls, got 6) while other test suites ran in parallel. The rerun passed, and -count=5 -run 'TestRDSFamilyExpiryCommand|ExtendedSupportUnavailable' ./cmd also passed. The test uses stub HTTP transports, and this change doesn't affect it.
  • go mod tidy -diff: clean
  • govulncheck, run the way CI does it (go install golang.org/x/vuln/cmd/govulncheck@v1.1.4, then govulncheck ./... at the root):
    • main (before): exit 0. Module results list GO-2026-6866 and GO-2026-6860 (x/net@v0.61.0) plus GO-2026-5932 (x/crypto openpgp, no fix available)
    • this branch: exit 0, "Your code is affected by 0 vulnerabilities". GO-2026-6860 and GO-2026-6866 are gone. Only the unfixable GO-2026-5932 is left, and nothing calls it.

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • No user-facing changes are included in this release. The app’s visible features, interface, and documented behavior remain unchanged. No new actions or settings are available, and existing workflows continue to behave as before. This update does not change how the app looks or how people interact with it.

Bumps golang.org/x/net from v0.61.0 to v0.62.0 (go get + go mod tidy;
only go.mod/go.sum change). Mirrors
LeanerCloud/cloud-commitments-platform#1564.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between 053407d and e1ad318.

Files ignored due to path filters: 1
  • go.sum is excluded by !**/*.sum
Files selected for processing: 1
  • go.mod

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The golang.org/x/net indirect dependency in go.mod is upgraded from v0.61.0 to v0.62.0.

Changes: Dependency version update

Layer / File(s) Summary
Update indirect dependency version
go.mod
The declared version of golang.org/x/net changes from v0.61.0 to v0.62.0.

Priority: Low

Estimated code review effort: 1 (Trivial) | ~3 minutes

Change: Other

Suggested reviewers: cristim

Merge Risk: Minimal · up to e1ad3

The dependency update is ready to merge based on the supplied scope and verification status.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies the dependency update and names the related security findings.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@IAmJSD

IAmJSD commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

Independent review (IAmJSD's agent, fresh context, given only the diff, the issue and the PR text): VERDICT: APPROVE e1ad3183ae136acc3c08bba92af78890bd9d182e

Blocking:

  • none

Non-blocking:

  • No linked issue. That's fine for a deps-only security bump, and the PR body uses no closing keyword.

Attacked:

  • Diff (origin/main...e1ad3183) touches only go.mod and go.sum: x/net v0.61.0 -> v0.62.0, indirect. No other requirement moves. The v0.62.0 hashes are the same as in mcp#122 and go#659, and go mod verify says "all modules verified". go mod tidy -diff is clean.
  • go build -o /dev/null ./..., go vet ./... and go vet -tags integration ./... pass. A plain go build ./... fails on main too, because the output name clashes with ./cmd. go test -race -short -count=1 ./... passes (cmd ok in 240s, with -race on a loaded shared VM). I didn't hit the TestRDSFamilyExpiryCommand flake the body mentions.
  • Before/after: I ran govulncheck v1.1.4 with govulncheck ./... at the root, the way CI does. On origin/main (053407d) the module results list GO-2026-6860, GO-2026-6866 and GO-2026-5932. On this head only GO-2026-5932 is left (x/crypto openpgp, no fix available, not called). Both runs exit 0.

Body-stale:

  • none. All the verification claims reproduce.

Reviewer: rG5. Bar while the maintainers are away (set by IAmJSD as acting owner): one approving independent review on the head, two for money, auth and security paths.

@IAmJSD
IAmJSD merged commit 44a0b93 into LeanerCloud:main Oct 28, 2026
12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant