Skip to content

fix(deps): bump golang.org/x/net to v0.62.0 (GO-2026-6860, GO-2026-6866) - #659

Merged
cristim merged 6 commits into
LeanerCloud:mainfrom
IAmJSD:fix/xnet-062
Oct 28, 2026
Merged

cristim merged 6 commits into
LeanerCloud:mainfrom
IAmJSD:fix/xnet-062

Conversation

@IAmJSD

@IAmJSD IAmJSD commented Oct 28, 2026 •

Copy link
Copy Markdown
Collaborator

Why

govulncheck (v1.1.4, module-level results) flags golang.org/x/net@v0.60.0 for GO-2026-6860 and GO-2026-6866 in providers/azure, providers/gcp and ci_cd_sanity_tests. Both are fixed in v0.62.0. This is the same bump as LeanerCloud/cloud-commitments-platform#1564.

What

  • In each module that required x/net below v0.62.0 (ci_cd_sanity_tests, providers/azure, providers/gcp): go get golang.org/x/net@v0.62.0 && go mod tidy.
  • x/net v0.62.0 needs newer versions of its golang.org/x siblings, so those requirements go up with it: x/crypto v0.57.0 -> v0.58.0, x/sys v0.48.0 -> v0.49.0, x/text v0.42.0 -> v0.43.0, x/sync v0.23.0 -> v0.24.0 (sync only in gcp and ci_cd_sanity_tests).
  • Only go.mod/go.sum in those three modules change. pkg, providers/aws, go.work and go.work.sum stay the same. I left the open Dependabot PRs alone, so whichever lands second may need a trivial go.mod/go.sum rebase.

Verification

Run locally with go1.26.10 (GOTOOLCHAIN=auto), AWS_CONFIG_FILE=/dev/null AWS_SHARED_CREDENTIALS_FILE=/dev/null AWS_EC2_METADATA_DISABLED=true:

  • In each touched module, workspace mode (go.work):
    • go build ./...: OK in all three
    • go vet ./...: OK in all three
    • go test -short -count=1 ./...: OK (ci_cd_sanity_tests: 2 pkgs ok, providers/azure: 14, providers/gcp: 8, no failures)
  • make build (all modules): OK
  • Standalone check matching the CI "Verify standalone provider modules" step, with GOWORK=off, for providers/aws, providers/azure, providers/gcp and ci_cd_sanity_tests: go build -mod=readonly ./..., go test -mod=readonly -race -short -count=1 ./... and go mod tidy -diff all pass.
  • govulncheck, run the way CI does it (go install golang.org/x/vuln/cmd/govulncheck@v1.1.4, then (cd "$mod" && govulncheck ./...) for pkg providers/aws providers/azure providers/gcp ci_cd_sanity_tests):
    • main (before): every module exits 0. azure, gcp and ci_cd_sanity_tests list GO-2026-6866 and GO-2026-6860 (x/net@v0.60.0) plus GO-2026-5932 in their module results.
    • this branch: every module exits 0, and none of them reports GO-2026-6860 or GO-2026-6866 any more. Only GO-2026-5932 is left (x/crypto openpgp, no fix available, nothing calls it).

🤖 Generated with Claude Code

Summary by CodeRabbit

  • Chores
    • Updated underlying components used by CI checks and the Azure and GCP integrations. These maintenance updates do not change user-facing behavior or public interfaces. No new features or behavior changes are included in this update.

Bumps golang.org/x/net from v0.60.0 to v0.62.0 in ci_cd_sanity_tests,
providers/azure and providers/gcp (go get + go mod tidy per module).
x/net v0.62.0 raises the minimum x/crypto, x/sys, x/text and x/sync,
so those indirect requirements move with it. Mirrors
LeanerCloud/cloud-commitments-platform#1564.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Note

Reviews paused

It looks like this branch is under active development. To avoid overwhelming you with review comments due to an influx of new commits, CodeRabbit has automatically paused this review. You can configure this behavior by changing the reviews.auto_review.auto_pause_after_reviewed_commits setting.

Use the following commands to manage reviews:

  • @coderabbitai resume to resume automatic reviews.
  • @coderabbitai review to trigger a single review.

Use the checkboxes below for quick actions:

  • ▶️ Resume reviews
  • 🔍 Trigger review

No actionable comments were generated in the recent review.

Recent review info
Run configuration
Commits

Reviewing files that changed from the base of the PR and between a8ceac1 and 2f80e8e.

Files ignored due to path filters: 3
  • ci_cd_sanity_tests/go.sum is excluded by !**/*.sum
  • providers/azure/go.sum is excluded by !**/*.sum
  • providers/gcp/go.sum is excluded by !**/*.sum
Files selected for processing: 1
  • providers/gcp/go.mod

Included review availability: This review used your included allowance. Your plan provides up to 1 included review per hour; 0 remain after this review.

Walkthrough

The CI sanity tests, Azure provider, and GCP provider Go modules update indirect golang.org/x dependency versions.

Changes: Go dependency updates

Layer / File(s) Summary
Update module dependency requirements
ci_cd_sanity_tests/go.mod, providers/azure/go.mod, providers/gcp/go.mod
The modules update indirect requirements for golang.org/x/crypto, x/net, x/sys, x/text, and x/sync. The CI sanity tests module updates x/sync; the GCP module updates x/net.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Suggested reviewers: cristim

Merge Risk: Minimal · previous review 2f80e

The dependency update is mergeable; resolve any overlapping Dependabot change while preserving v0.62.0.

Pre-merge checks: Passed 5
Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title clearly and concisely identifies the dependency update to golang.org/x/net v0.62.0 and the related security advisories.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (1 skipped: 1 unsupported.)

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@IAmJSD

IAmJSD commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

Independent review (IAmJSD's agent, fresh context, given only the diff, the issue and the PR text): VERDICT: APPROVE 0290050221fe91d5676b61fd923b44810f68d073

Reviewed head 02900502. It moved during the review from b6fa45b4 by merging main (e9a8329, #651 pkg dependency group), and the PR's own three-dot diff is byte-identical to before. I reran everything below on 02900502.

Blocking:

  • none

Non-blocking:

Attacked:

  • Diff (origin/main...02900502) changes only go.mod and go.sum in ci_cd_sanity_tests, providers/azure and providers/gcp. x/net goes v0.60.0 -> v0.62.0, and its siblings go up with it: crypto 0.58.0, sys 0.49.0, text 0.43.0, sync 0.24.0. pkg and providers/aws require older x/sync and x/sys and are untouched. That's fine, since MVS picks the max in workspace mode and they don't depend on x/net. go.work and go.work.sum are unchanged. The hashes match what mcp and cli already carry for crypto/sync/sys and the new x/net.
  • In each of the 5 workspace modules: go build ./..., go vet ./... and go vet -tags integration ./... pass. With GOWORK=off, go build -mod=readonly ./... and go mod tidy -diff pass in each module, the same as the standalone-module CI step. go test -race -short -count=1 ./... passes in the three changed modules (azure 14 pkgs, gcp 8, ci_cd_sanity_tests 2).
  • Before/after: I ran govulncheck v1.1.4 with (cd $mod && govulncheck ./...) over pkg providers/aws providers/azure providers/gcp ci_cd_sanity_tests, the way CI does. On origin/main (e9a8329, the same main this head merged), azure, gcp and ci_cd_sanity_tests list GO-2026-6860 and GO-2026-6866, plus GO-2026-5932. On this head only GO-2026-5932 is left (no fix available, not called). pkg and aws are clean both before and after. Every module exits 0 both before and after.

Body-stale:

  • none. All the verification claims reproduce.

Reviewer: rG5. Bar while the maintainers are away (set by IAmJSD as acting owner): one approving independent review on the head, two for money, auth and security paths.

@IAmJSD

IAmJSD commented Oct 28, 2026

Copy link
Copy Markdown
Collaborator Author

Independent review (IAmJSD's agent, fresh context, given only the diff, the issue and the PR text): VERDICT: APPROVE a8ceac121c7b1daef062abef48968dd169e929a1

Blocking:

  • none

Non-blocking:

Attacked:

  • I reviewed head a8ceac1. It moved during my review: b50ca78 plus one more main merge, which brought in Dependabot chore(deps): Bump github.com/Azure/azure-sdk-for-go/sdk/azidentity from 1.14.0 to 1.15.0 in /ci_cd_sanity_tests in the gomod-ci-cd-sanity-tests group #657, azidentity 1.14.0 -> 1.15.0 in ci_cd_sanity_tests. That merge doesn't touch any golang.org/x line. The head is the original bump commit plus three main merges. git diff origin/main...HEAD touches only go.mod/go.sum in ci_cd_sanity_tests, providers/azure and providers/gcp. go.work and go.work.sum are unchanged.
  • Re-checked the x/net bump after the main merge. azure, gcp and ci_cd_sanity_tests require x/net v0.62.0, with crypto v0.58.0, sys v0.49.0, text v0.43.0 and sync v0.24.0. go list -m golang.org/x/net resolves to v0.62.0 in all five modules in workspace mode, and also standalone (GOWORK=off go list -m all) in the three modules that pull it in. pkg and providers/aws don't depend on x/net at all.
  • In each module (pkg, aws, azure, gcp, ci_cd_sanity_tests), ran GOWORK=off go mod tidy -diff, GOWORK=off go build -mod=readonly ./... and go vet ./..., all clean. Ran GOWORK=off go test -mod=readonly -race -short -count=1 ./... in azure, gcp and ci_cd_sanity_tests, all ok.
  • Ran govulncheck v1.1.4 (-show verbose ./...) in all five modules. Every module exits 0, and GO-2026-6860 and GO-2026-6866 no longer appear anywhere. Only GO-2026-5932 is left (x/crypto openpgp, no fix available, not called), as the body says.

Body-stale:

  • none

Reviewer: rH3. Bar while the maintainers are away (set by IAmJSD as acting owner): one approving independent review on the head, two for money, auth and security paths.

@cristim
cristim merged commit 8785de4 into LeanerCloud:main Oct 28, 2026
15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants