Repository navigation
Conversation
Since the GTK preview is a Gtk.GLArea, GTK on X11 draws any window holding it through GL, and brings in the other widgets' pixmaps with GLX texture-from-pixmap. On some Mesa setups that reads a pixmap before the X server finished drawing it, so labels, buttons and the G-code editor glitch sporadically, also on pages without the preview. 2.9 has no GLArea and is not affected. software-draw-surface makes GTK upload the changed parts of the window with a plain copy instead. The reporter confirmed it removes the glitching. A value the user set is kept. Fixes LinuxCNC#4754
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Since the GTK preview is a Gtk.GLArea, GTK on X11 draws any window holding it through GL, and brings in the other widgets' pixmaps with GLX texture-from-pixmap. On some Mesa setups that reads a pixmap before the X server finished drawing it, so labels, buttons and the G-code editor glitch sporadically, also on pages without the preview. 2.9 has no GLArea and is not affected.
software-draw-surface makes GTK upload the changed parts of the window with a plain copy instead. The reporter confirmed it removes the glitching. A value the user set is kept.
Fixes #4754