Repository navigation
Feature/notifications location requests - #25
Merged
SURYANSH-RAI merged 23 commits intoNov 13, 2026
Merged
SURYANSH-RAI merged 23 commits into
SURYANSH-RAI merged 23 commits into
Conversation
Notification e-mails were sent inline after the action and a failure was only logged, so a mail outage lost the message. - Migration 0014: notification_outbox (unique dedupe key, attempts, lease, last error) and location_requests (used by part 2); the sweep removes sent notifications after 30 days and location requests after a day - An intro request and its notification, and an acceptance and its notice to the requester, commit in one transaction - The worker delivers queued notifications with a 2-minute lease and backoff retries (30s ... 15 min, 5 attempts); details are read at send time and an interaction that no longer applies is closed without sending; replays never send twice - E-mails carry a deep link to the connection on the Connections page; the notifier gains location-request and reply messages - Real-Postgres tests: queued once with the request, delivered with the link, acceptance notice, and a failed send kept for retry
…rt 2) "Ping zone" only overwrote the sender's own zone for every connection; there was no way to ask a connection where they are, and no reply. - domain/connection/location.rules.ts: a request is a question, not tracking. One open request per direction of an accepted connection; unanswered requests expire after 30 minutes; a shared zone is visible only to the person who asked, for 15 minutes; 10 requests per person and hour - LocationRepository (Postgres): creating a request and answering it (a configured zone, or "not now") each queue their notification in the same transaction, so the interaction is never lost - Connections page: "Ask where they are", an incoming request with "Share with <name>" / "Not now", the reply or decline for the asker, and the existing broadcast labelled "Share with all my connections"; each connection has an anchor for e-mail deep links - Tests: state and rules, the use cases, real-Postgres visibility, expiry and replacement, and a browser run where the worker e-mails the request, acceptance, location request and reply
Integration tests skip themselves without Postgres or Keycloak, which let CI pass with the Keycloak suites never running. CI now starts the compose Postgres and Keycloak, syncs the realm, sets REQUIRE_SERVICES so a global setup refuses to start without them, and checks the JSON report so any skipped test fails the job. Workers accept an optional event scope for tests.
When every explanation of a shortlist was already cached the model was not asked again and the list fell back to score order, so a refresh that changed nothing reshuffled a stored, reranked list. The model's order is now kept for the exact shortlist (keyed by all of its pair keys) and reused on a full cache hit; erasure, removal, hiding and housekeeping clear it with the explanations.
Runs the real embed and match workers against Postgres with deterministic fake providers: the first person to save gets matches once others arrive, the reranked order is stored and survives a refresh, and a worker killed between stages is recovered without publishing a stale revision.
Two people asking each other at the same moment both passed the check-then-insert and created two crossing requests. The repository now takes a lock on the pair of people and applies the same refusal rule inside the insert's transaction, so exactly one request is created.
The same request sent twice, crossing requests, an accept racing a decline, a repeated location question and overlapping roster imports each leave exactly one outcome against a real Postgres.
Two organizations' events and one person attending both: profiles, candidates, stored matches, intros, contacts, location requests and removal never cross from one event to the other, even with ids taken from it.
Playwright (pinned 1.63.0, approved) drives the built app and worker against the compose Postgres and Keycloak: organizer setup and import, invited and uninvited sign-in, profiles, background matches, search, intro consent, the venue question, isolation from a third attendee, analytics and closing the event; plus phone sign-in, single-use magic links, a tampered cookie, sign-out and phone-width layouts. Login codes come from the app's dev e-mail log. The CI job keeps the report and logs on failure.
Cookies are read with SESSION_SECRET and then any SESSION_SECRET_PREVIOUS value, and always sealed with the current one. Terraform keeps two secret slots and a session_secret_active switch, so a rotation regenerates the inactive slot and makes it active in one apply. Login codes get their own OTP_PEPPER so a rotation leaves codes in flight valid.
The worker reports queue backlog, waiting time and permanent failures once a minute with a heartbeat; every search reports its latency and failures; every model call reports its outcome. They are written as CloudWatch embedded metrics (no agent or new service) when METRICS_NAMESPACE is set. Terraform adds alarms for a stopped worker, matching and notification backlogs, failed jobs and notifications, slow or failing search and a sustained model failure rate, plus a dashboard. Each alarm names its runbook section.
Two workers saving match lists that named each other deadlocked: each locked its own profile row FOR UPDATE, then its inserts took key-share locks on the other's row through the foreign keys. Found by the capacity check (300 attendees, 2 workers). The revision check now locks FOR NO KEY UPDATE, which still blocks a concurrent profile save but not those foreign-key locks.
Retrieval took the 50 nearest people and only then dropped intents the viewer does not welcome, so a mentor whose nearest neighbours were all mentors got no matches even with a mentee in the event. Found by the capacity check (1 of 300 attendees). Retrieval now applies the viewer's welcomed intents in the query, before the limit, for profile matches and search (part of the shared search cache key; retrieval version r3).
npm run capacity:check creates a throwaway event of the chosen size, saves every profile, runs the real embed and match workers until the queue is quiet, runs concurrent searches through the real use case, and reports time to first match lists, search p50/p95, failures and model calls per attendee and search against the budgets in the runbook, then removes everything. It uses a free deterministic embedding by default (EMBEDDING_PROVIDER=hash, refused in production) or the deployment's real providers with --providers configured. Locally: 300 attendees matched in 6 s with search p95 83 ms; 1000 attendees in 25 s with search p95 169 ms.
npm run db:verify checks a database is usable: pgvector, every migration applied from the same file (either line ending), core tables present, and row counts against a source with --compare. npm run db:restore-rehearsal dumps the compose database, restores it into a scratch database, verifies it and removes it, timing each step (locally 1.3 s). CI now refuses a change to a released migration or a new migration that would break the previous image (drop, rename, type change, truncate) unless the line is marked as a deliberate contract step.
The GitHub deploy role could push to the web, Keycloak and migrate image repositories but not the worker's, while every release pushes a worker image, so a real deploy would stop at "Build & push worker" with access denied. The worker repository is now in the push statement.
The deploy workflow takes an environment (production or staging). Staging is its own Terraform stack (match-maker-staging-*, example variables and separate state key), its jobs run in the GitHub 'staging' environment and refuse to start unless that environment names the staging stack, so they never fall back to production settings. promote_tag copies the images a staging deploy tested into production unchanged (buildx imagetools, same account) and then migrates and rolls out as usual; production's deploy role may read the staging repositories when image_promotion_source is set. Pushes to main still deploy to production as before.
docs/OPERATIONS.md: the service targets and measured capacity, the release path through staging and promotion, migration rules and rollback, what to do for every alarm, database restore with verification, rotation of each secret, running tools against the private database, and the launch checklist. The worker image now carries the operator tools so account commands and the Keycloak sync can run as one-off tasks inside the VPC.
TypeScript 6 (used by the editor) deprecates baseUrl and reported it on apps/web and packages/auth (inherited from tsconfig.base.json). Path aliases do not need it: the entries are now relative to the file that declares them. Type-checks clean with TypeScript 5.7 and 6.0.
Feature/operations readiness
Feature/browser acceptance suite
Feature/ci acceptance coverage
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
R23: Reliable notifications and venue location requests
A location request reaches the intended accepted connection, who can reply voluntarily. Stale zones expire, and notification failures don't lose the interaction.
Decisions (recommended options):
Changes:
notification_outbox,location_requests); intro request/accept enqueue atomically;notification.worker.ts; notifier with links and location messages; retention sweeps.